search

anitab-org / mentorship-backend

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the backend of this system.
https://mentorship-backend-temp.herokuapp.com/
GNU General Public License v3.0
196 stars 449 forks source link

Enhancement: Update mentorship_relation.py to use enum class #1151

Open ciheanyi opened 2 years ago

ciheanyi commented 2 years ago

Fixes issue https://github.com/anitab-org/mentorship-backend/issues/1143. Code within isValidStatefunction now uses an enum class when completing check.

welcome[bot] commented 2 years ago

Hello there!👋 Welcome to the project!💖 Thank you and congrats 🎉 for opening your first PR on this project.✨ Please ensure your Pull Request meets the Commit Message Style Guide. We will review it soon! Until then you can check out the README.md for more details on it.

AnitaB.org Open Source is an inclusive community, committed to creating a safe and positive environment 🌸 Please follow our Code Of Conduct.

Feel free to join our community at AnitaB.org Open Source Zulip Community to be kept up to date with our projects discussions and community activities. Hope you have a great time here :)

ciheanyi commented 2 years ago

Hi just dropping this again for a review for the pull request. I also think there may be some dependency updates required that are causing the unit tests to fail. I believe the way markup is imported may have recently deprecated for some jinja2 versions. When we modified dependency locally, unit tests ran successfully. Created bug here