search

anitab-org / mentorship-backend

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the backend of this system.
https://mentorship-backend-temp.herokuapp.com/
GNU General Public License v3.0
196 stars 449 forks source link

Bug Report: Library dependencies in unit tests out of date #1153

Open ciheanyi opened 2 years ago

ciheanyi commented 2 years ago

Describe the bug

When running the provided unit tests for this repo receiving error: "ImportError: cannot import name 'Markup' from 'jinja2'" After further investigaton, discovered that Jinja2>=2.10.1 deprecated Markup command

To Reproduce

Steps to reproduce the behavior:

  1. Submit a pull request with a commit
  2. Code runs on unit tests
  3. See error

Screenshots

Screen Shot 2022-04-22 at 11 12 21 PM

Desktop (please complete the following information):

Additional context

potentially use this instead to fix:

from jinja2.utils import markupsafe markupsafe.Markup() Markup('')

OR have to change dependency versions, when done locally all unit tests ran as usual

welcome[bot] commented 2 years ago

Hello there!👋 Welcome to the project!💖

Thank you and congrats 🎉 for opening your very first issue in this project. AnitaB.org Open Source is an inclusive community, committed to creating a safe and positive environment 🌸 Please follow our Code Of Conduct 🙌 You can learn more about the community on our website and documentation repository.

You may submit a PR on the same if you like! Please follow our Commit Message Style Guide and Coding Standards while sending PRs. If you want to report a bug 🐞, please follow our bug_report.md template. Please make sure you include steps to reproduce it and be patient we will get back to you as soon as we can 👀

Also, feel free to join us on AnitaB.org Open Source Zulip Community 🤝 We have different streams for each active repository for discussions.👩🏻‍💻🧑🏻‍💻 For mentorship-backend, join #mentorship-system stream! Hope you have a great time here :)