anitab-org / mentorship-backend

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the backend of this system.
https://mentorship-backend-temp.herokuapp.com/
GNU General Public License v3.0
196 stars 449 forks source link

fix: psycopg2-binary version fix #1172

Open Raghunandhan8818 opened 1 year ago

Raghunandhan8818 commented 1 year ago

Description

Issue: The previous version of psycopg2-binary (2.8.6) was throwing an error during installation, stating "The license_file parameter is deprecated, use license_files instead."

Solution: After conducting thorough research, I upgraded the psycopg2-binary library to version 2.9.6, which resolved the aforementioned issue. And I have specified the latest version (3.3.3) for the package pre-commit so that there wont be any version conflicts in future as well. For the second issue , I have upgraded all the dependencies so that the projects runs without any errors.

Fixes #1170 and #1153

Type of Change:

Code/Quality Assurance Only

How Has This Been Tested?

I have tested the above installation by running pip install -r requirements.txt , and it gave no errors. All the dependencies installed successfully.

Below is the result before version upgradation. Screenshot from 2023-08-25 21-22-46

Result after version upgradation. All the dependencies installed successfully ! image

I have updated the dependencies and the projects works without any error !!

image

Checklist:

Code/Quality Assurance Only

welcome[bot] commented 1 year ago

Hello there!👋 Welcome to the project!💖 Thank you and congrats 🎉 for opening your first PR on this project.✨ Please ensure your Pull Request meets the Commit Message Style Guide. We will review it soon! Until then you can check out the README.md for more details on it.

AnitaB.org Open Source is an inclusive community, committed to creating a safe and positive environment 🌸 Please follow our Code Of Conduct.

Feel free to join our community at AnitaB.org Open Source Zulip Community to be kept up to date with our projects discussions and community activities. Hope you have a great time here :)

Raghunandhan8818 commented 1 year ago

Hello @isabelcosta ! This is my first try to the open source contribution and would love to contribute to this project. Let me know if I have to do anything else to get this PR merged.

Raghunandhan8818 commented 1 year ago

Hello @isabelcosta @vj-codes !

I was working on the dependencies and now everything works fine on python 3.7. There was problem with Jinja2 and Psycopg2-Binary .When I submitted my PR ,all the dependencies were installed successfully but it is throwing error in running the tests as TypeError: delete() got an unexpected keyword argument 'request_id' .

Shall I work on resolving those errors as well ? What should I do now ?

image