Upload photos to Amazon S3

anitab-org / mentorship-backend

Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the backend of this system.

https://mentorship-backend-temp.herokuapp.com/

GNU General Public License v3.0

195 stars 448 forks source link

Upload photos to Amazon S3 #152

Open isabelcosta opened 5 years ago

isabelcosta commented 5 years ago

Description

As a user of Mentorship System, I need to be able to upload profile image into the backend, so that I can make my profile more personal.

You can find some info about S3 urls in this file of Android app.

Expected Input: Image will be sent as an encoded string

Acceptance Criteria

Update [Required]

[ ] Save User images on Amazon S3
[ ] Save URL on UserModel photo_url field
[ ] Return photo_url on appropriate APIs

Definition of Done

[ ] All of the required items are completed.
[x] Approval by 1 mentor.

Estimation

5 hours

DivyeshPuri commented 5 years ago

@isabelcosta What format of input should I expect when developing this feature will the image be uploaded in bytecode or via request?

isabelcosta commented 5 years ago

@DivyeshPuri I wish I knew :P @m-murad can you help to clarify this, please?

m-murad commented 5 years ago

Image will be uploaded as an encoded string

isabelcosta commented 5 years ago

@DivyeshPuri answer up here ^^ @m-murad Thank you sooooo much

ethicalrushi commented 5 years ago

Can I work on this issue??

isabelcosta commented 5 years ago

@ethicalrushi if you still want to work on this you can ;)

CleverFool77 commented 5 years ago

Is this issue available @isabelcosta ? If yes, then I would like to work on this :)

CleverFool77 commented 5 years ago

Is this the process -

Get the encoded string of image from frontend
Save the image decoded from string in aws s3.
Get the photo url from aws and store it in db
Return photto url in the update user profile api endpoint.

isabelcosta commented 5 years ago

@CleverFool77 a practice here in the community is to wait for maintainers to approve that you work on the issue before sending a PR, so that we can manage better the issues. Keep that in mind for future contributions please

CleverFool77 commented 5 years ago

I'll surely keep that in mind from next time @isabelcosta

codesankalp commented 3 years ago

Is this issue available now to work? I want to work on this issue.

isabelcosta commented 3 years ago

@anna4j @codesankalp this issue is already completed, we are blocked by infrastructure needs such as AWS.