search

anitab-org / mentorship-flutter

THIS PROJECT IS ARCHIVED. Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Flutter version of this project.
https://github.com/anitab-org/mentorship-flutter/blob/apk/app-release.apk
MIT License
59 stars 58 forks source link

Last page bug due to Pagination #107

Open techno-disaster opened 4 years ago

techno-disaster commented 4 years ago

Describe the bug

Right now if the last page does not have all 20 members (the number of people we request per page). The members get repeated. This is probably due to a small bug in hasReachedMax, to fill the 20 limit.

PS: The data is getting called for all the pages (including the last one) as expected, you can see it in the logs when you scroll to the end. Only the members aren't shown on the app.

To Reproduce Steps to reproduce the behavior: Go to members page and scroll to the end.

Screenshots

Screenshot_20200622-084911

Anirudhk07 commented 4 years ago

Can I take this ?

techno-disaster commented 4 years ago

Hey @Anirudhk07 sure. assigning it to you

techno-disaster commented 4 years ago

@Anirudhk07 Any update on the issue?

Akanksha1212 commented 4 years ago

Making this issue available for others as there's no response from @Anirudhk07.

techno-disaster commented 4 years ago

@bharat-1809 can you take this up?

bharat-1809 commented 4 years ago

@Techno-Disaster Sure, thanks :)

techno-disaster commented 4 years ago

Hey @bharat-1809 any updates?

bharat-1809 commented 4 years ago

@Techno-Disaster I am still working on it. Sorry for the delay.

techno-disaster commented 4 years ago

no problem, we just need a update every 3 days :) feel free to ask of you are stuck somewhere.

bharat-1809 commented 4 years ago

@Techno-Disaster I think the issue is already solved. The list didn't get repeated. Please have a look. 20200713_211408

techno-disaster commented 4 years ago

Yes, i looked into this and found out an issue on the backend, lets keep this on hold for now. Will raise an issue on the backend repo