Closed isabelcosta closed 4 years ago
@bartekpacia @Techno-Disaster let's leave this to a newcomer, I have no idea the complexity of this, but with your guidance, I feel a newcomer could do this
@bartekpacia @Techno-Disaster let's leave this to a newcomer, I have no idea the complexity of this, but with your guidance, I feel a newcomer could do this
yep, looks easy. Lets see if anyone picks it up
@bartekpacia @Techno-Disaster let's leave this to a newcomer, I have no idea the complexity of this, but with your guidance, I feel a newcomer could do this
yep, looks easy. Lets see if anyone picks it up
unless that also requires bloc implementation. 🤦. Will have to check.
Hey @isabelcosta ! I'm Mahe. Can I please try resolving this issue?
@MaheKhan sure. assigned it to you
Hey @Techno-Disaster ! I tried following the step by step instructions given here: https://github.com/anitab-org/mentorship-flutter After installing Flutter SDK and Android SDK, I cloned the mentorship-flutter repository on my system. I opened it on my external IDE (ATOM). I switched to the beta using 'flutter channel beta' command. When I then give the 'flutter run' command in the flutter console, I get this error;
But, when I check the contents of the mentorship-flutter repository, the pubspec.yaml file is already there. here;
@MaheKhan cd into the app directory
Yes, thankyou.
Yayy! I was finally able to run the flutter app on my system. It might not be a big achievement, but I am just glad I didn't give up midway and finally got the app running.
Now, I myself can see the issue mentioned in the description by @isabelcosta .
I think it's the register_screen.dart file in the register folder of the repository that would require the changes. Am I correct, @Techno-Disaster ?
I was googling how to add hyperlinks to text in dart files. So that I could convert the phrases; Code of Conduct, Terms, and Privacy Policy; into hyperlinks.
I think it's the register_screen.dart file in the register folder of the repository that would require the changes. Am I correct, @Techno-Disaster ?
yes @MaheKhan . Great work until now, keep it up 👍
@MaheKhan great to see @Techno-Disaster is helping you out :) Excited to see you working on this issue 🤗
@MaheKhan we have already used url_launcher in the project. You can refer to this stackoverflow link incase you are stuck
Hey, @Techno-Disaster ! I was able to convert the desired pieces of text into hyperlinks. I used 'GestureDetector' widget. When clicked, the hyperlinks cause browser to open those respective webpages. But now the texts is getting overflowed because I removed the 'Flexible' widget.
@MaheKhan Try using Richtext. All the widgets you will need are already there in the stack overflow link i commented earlier
Hey, @Techno-Disaster ! Instead of using GestureDetector, I now used RichText ; like you told me to. But, I am unable to fix the text overflow issue. The stackoverflow link you provided, and many others I searched, none of them helped me. I tried wrapping the row using 'Wrap', but to no avail.
I tried using Expanded and Flexible too.
Please guide me some more.
Okay, It's done!!!!! <3
Great work figuring it out yourself @MaheKhan . was busy so couldn't help you earlier but congrats :100: Next steps: make a PR :)
Hey, @Techno-Disaster.
I improved it a bit. Earlier the check box was not aligned with the text. Now, it is!
@Techno-Disaster , would you please help with making a PR? I haven't done it before.
@MaheKhan sure, first push your local changes to your forked github repo, then head on over to pull requests, click "New Pull Request". Select "compare across forks" and select your fork, then click "create pull request" . A template should load up for you. Make the required changes in the template, and click Create Request and you are done :). Feel free to ping me if you get stuck in between.
Done. Made my first PR! Please tell me what you think of it.
@Techno-Disaster, hey! Please review my PR. :)
Yes @MaheKhan , working on it. Need to make sure everything is right
For next person that picks this up, the PR #73 was almost done, so you can continue this work on your PR :)
Moved to #97
Description
As a user of the system, I need to have links to terms and conditions on Register screen so that I can be aware of Terms of use, Code of Conduct and Privacy Policy.
On Registration Screen we need to have a proper text with the Terms and Conditions check box.
Text:
"By checking this box, I affirm that I have read and accept to be bound by the AnitaB.org Code of Conduct, Terms, and Privacy Policy. Further, I consent to the use of my information for the stated purpose."
Links to add:
Code of Conduct: https://ghc.anitab.org/code-of-conduct/ Terms of use: https://anitab.org/terms-of-use/ Privacy Policy: https://anitab.org/privacy-policy/
Screenshots of the issue
Android version:
Flutter current version:
Acceptance Criteria
Update [Required]
Definition of Done
Estimation
🤷♀️