anitab-org / mentorship-flutter

THIS PROJECT IS ARCHIVED. Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the Flutter version of this project.
https://github.com/anitab-org/mentorship-flutter/blob/apk/app-release.apk
MIT License
59 stars 58 forks source link

Add links to Terms, Policy and CoC on Sign Up screen #60

Closed isabelcosta closed 4 years ago

isabelcosta commented 4 years ago

Description

As a user of the system, I need to have links to terms and conditions on Register screen so that I can be aware of Terms of use, Code of Conduct and Privacy Policy.

On Registration Screen we need to have a proper text with the Terms and Conditions check box.

Text:

"By checking this box, I affirm that I have read and accept to be bound by the AnitaB.org Code of Conduct, Terms, and Privacy Policy. Further, I consent to the use of my information for the stated purpose."

Links to add:

Code of Conduct: https://ghc.anitab.org/code-of-conduct/ Terms of use: https://anitab.org/terms-of-use/ Privacy Policy: https://anitab.org/privacy-policy/

Screenshots of the issue

Android version:

image

Flutter current version:

image

Acceptance Criteria

Update [Required]

Definition of Done

Estimation

🤷‍♀️

isabelcosta commented 4 years ago

@bartekpacia @Techno-Disaster let's leave this to a newcomer, I have no idea the complexity of this, but with your guidance, I feel a newcomer could do this

techno-disaster commented 4 years ago

@bartekpacia @Techno-Disaster let's leave this to a newcomer, I have no idea the complexity of this, but with your guidance, I feel a newcomer could do this

yep, looks easy. Lets see if anyone picks it up

techno-disaster commented 4 years ago

@bartekpacia @Techno-Disaster let's leave this to a newcomer, I have no idea the complexity of this, but with your guidance, I feel a newcomer could do this

yep, looks easy. Lets see if anyone picks it up

unless that also requires bloc implementation. 🤦. Will have to check.

ghost commented 4 years ago

Hey @isabelcosta ! I'm Mahe. Can I please try resolving this issue?

techno-disaster commented 4 years ago

@MaheKhan sure. assigned it to you

ghost commented 4 years ago

Hey @Techno-Disaster ! I tried following the step by step instructions given here: https://github.com/anitab-org/mentorship-flutter After installing Flutter SDK and Android SDK, I cloned the mentorship-flutter repository on my system. I opened it on my external IDE (ATOM). I switched to the beta using 'flutter channel beta' command. When I then give the 'flutter run' command in the flutter console, I get this error;

flutter

But, when I check the contents of the mentorship-flutter repository, the pubspec.yaml file is already there. here; atom

techno-disaster commented 4 years ago

@MaheKhan cd into the app directory

ghost commented 4 years ago

Yes, thankyou.

ghost commented 4 years ago

Yayy! I was finally able to run the flutter app on my system. mentorship-flutter It might not be a big achievement, but I am just glad I didn't give up midway and finally got the app running.

ghost commented 4 years ago

Now, I myself can see the issue mentioned in the description by @isabelcosta .

ghost commented 4 years ago

I think it's the register_screen.dart file in the register folder of the repository that would require the changes. Am I correct, @Techno-Disaster ?

ghost commented 4 years ago

I was googling how to add hyperlinks to text in dart files. So that I could convert the phrases; Code of Conduct, Terms, and Privacy Policy; into hyperlinks.

techno-disaster commented 4 years ago

I think it's the register_screen.dart file in the register folder of the repository that would require the changes. Am I correct, @Techno-Disaster ?

yes @MaheKhan . Great work until now, keep it up 👍

isabelcosta commented 4 years ago

@MaheKhan great to see @Techno-Disaster is helping you out :) Excited to see you working on this issue 🤗

techno-disaster commented 4 years ago

@MaheKhan we have already used url_launcher in the project. You can refer to this stackoverflow link incase you are stuck

ghost commented 4 years ago

Hey, @Techno-Disaster ! I was able to convert the desired pieces of text into hyperlinks. I used 'GestureDetector' widget. yay When clicked, the hyperlinks cause browser to open those respective webpages. yay2 But now the texts is getting overflowed because I removed the 'Flexible' widget.

techno-disaster commented 4 years ago

@MaheKhan Try using Richtext. All the widgets you will need are already there in the stack overflow link i commented earlier

ghost commented 4 years ago

Hey, @Techno-Disaster ! Instead of using GestureDetector, I now used RichText ; like you told me to. But, I am unable to fix the text overflow issue. The stackoverflow link you provided, and many others I searched, none of them helped me. I tried wrapping the row using 'Wrap', but to no avail.

ghost commented 4 years ago

I tried using Expanded and Flexible too.

ghost commented 4 years ago

Please guide me some more.

ghost commented 4 years ago

Okay, It's done!!!!! <3

ghost commented 4 years ago

final_mentorship

techno-disaster commented 4 years ago

Great work figuring it out yourself @MaheKhan . was busy so couldn't help you earlier but congrats :100: Next steps: make a PR :)

ghost commented 4 years ago

Hey, @Techno-Disaster.

I improved it a bit. Earlier the check box was not aligned with the text. Now, it is! kardala

ghost commented 4 years ago

@Techno-Disaster , would you please help with making a PR? I haven't done it before.

techno-disaster commented 4 years ago

@MaheKhan sure, first push your local changes to your forked github repo, then head on over to pull requests, click "New Pull Request". Select "compare across forks" and select your fork, then click "create pull request" . A template should load up for you. Make the required changes in the template, and click Create Request and you are done :). Feel free to ping me if you get stuck in between.

ghost commented 4 years ago

Done. Made my first PR! Please tell me what you think of it.

techno-disaster commented 4 years ago

@Techno-Disaster, hey! Please review my PR. :)

Yes @MaheKhan , working on it. Need to make sure everything is right

isabelcosta commented 4 years ago

For next person that picks this up, the PR #73 was almost done, so you can continue this work on your PR :)

techno-disaster commented 4 years ago

Moved to #97