search

anitab-org / mentorship-ios

THIS PROJECT IS ARCHIVED. Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the iOS application of this project.
GNU General Public License v3.0
14 stars 28 forks source link

reset login data when view disappear: #127

Closed iMostfa closed 4 years ago

iMostfa commented 4 years ago

Description

when login view is going to disappear, login data we should reset the login data, to avoid the appearance for it again when the user logs out, as a fix for this bug

result

Fixes #125

Type of Change:

Delete irrelevant options.

Code/Quality Assurance Only

How Has This Been Tested?

all tests passed, it doesn't affect them.

Checklist:

Delete irrelevant options.

Code/Quality Assurance Only

sunjunkie commented 4 years ago

@iMostfa Are you planning to make the changes requested by Yugantar?

iMostfa commented 4 years ago

@sunjunkie yes, sure

iMostfa commented 4 years ago

@sunjunkie @yugantarjain added a test case, and edited the comment.

yugantarjain commented 4 years ago

Hi @iMostfa, thanks a lot for working on this issue and the neat solution!

  1. I have a couple of very small new comments, please have a look.
  2. I can see changes in the LaunchScreen.storyboard file, are they required?
  3. You probably also need to pull the latest changes from the upstream develop branch
sunjunkie commented 4 years ago

Regarding 2, I think this is from Xcode and not something we need to worry about.

yugantarjain commented 4 years ago

Hi @iMostfa, any updates?

iMostfa commented 4 years ago

@yugantarjain I'm very sorry for being late, I've made the changed required, hopes everything is okay this time

yugantarjain commented 4 years ago

@yugantarjain I'm very sorry for being late, I've made the changed required, hopes everything is okay this time

No problem. Amazing work! I'm approving this, thank you!!