search

anitab-org / mentorship-ios

THIS PROJECT IS ARCHIVED. Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the iOS application of this project.
GNU General Public License v3.0
14 stars 28 forks source link

bug: 'Add Task' button in relation screen is enabled for an empty relation too #128

Closed yugantarjain closed 3 years ago

yugantarjain commented 4 years ago

Describe the bug The 'Add Task' button in the relation screen stays enabled even when the user is not in a mentorship relation. A task can only be added when a relation exists, hence this button shall be disabled in case the relation is nil.

To Reproduce Steps to reproduce the behavior:

  1. Withdraw from accepted relation (if any) from home screen
  2. Go to relation screen
  3. See 'Add Task' button is enabled (it shouldn't be)

Expected behavior The 'Add Task' button should be disabled when the user is not in a relation

Screenshots Add Task button is enabled

image

Smartphone (please complete the following information):

gsnsg commented 4 years ago

@yugantarjain Can I work on this issue? I got a working solution already

yugantarjain commented 4 years ago

@yugantarjain Can I work on this issue? I got a working solution already

Hi @gsnsg, thanks a lot for your interest in working on this issue! I've kept this as a good first time issue due to its simplicity.

I do have another issue in mind about improving the Relation Screen UI when the user is not in a mentorship relation (like the screenshot above). As you can see, as of now the app shows default "Mentee" and "Jan 1, 1970". We can hide them, and also have a message on the screen saying something like "You're not in a mentorship relation, you can find members and send a request from members page." and have a button that redirects the user to the members tab. Would you like to create an issue for this and work on it?

Zoha131 commented 4 years ago

@yugantarjain Can I work on this issue?

yugantarjain commented 4 years ago

@yugantarjain Can I work on this issue?

Hi sure. Assigned!