anitab-org / mentorship-ios

THIS PROJECT IS ARCHIVED. Mentorship System is an application that matches women in tech to mentor each other, on career development, through 1:1 relations during a certain period of time. This is the iOS application of this project.
GNU General Public License v3.0
14 stars 28 forks source link

Hide `Add Task` button if current relation is empty to fix #128 #150

Closed Zoha131 closed 3 years ago

Zoha131 commented 4 years ago

Description

I have used @ViewBuilder attribute to pass the appropriate View to the navigationBarItems(trailing:) method. Before collecting data from the server the id of currentRelation is 0 and if the user doesn't have any Relation then the server response for id would be nil. This is why I have checked both of the conditions.

Fixes #128

Type of Change:

Code/Quality Assurance Only

How Has This Been Tested?

I have manually tested the screens.

Has Relation No Relation
Simulator Screen Shot Simulator Screen Shot

Checklist:

Delete irrelevant options.

Code/Quality Assurance Only

welcome[bot] commented 4 years ago

Hello there!πŸ‘‹ Welcome to the project!πŸ’–

Thank you and congratsπŸŽ‰ for opening your first pull request.✨ AnitaB.org is an inclusive community, committed to creating a safe and positive environment.🌸Please adhere to our Code of Conduct and Contributing Guidelines.πŸ™Œ.We will get back to you as soon as we can.πŸ˜„

Feel free to join us on AnitaB.org Open Source Zulip Community.πŸ’– We have different streams for each active repository for discussions.✨ Hope you have a great time there!πŸ˜„

welcome[bot] commented 3 years ago

Congrats on merging your first pull request! πŸŽ‰πŸŽ‰πŸŽ‰ We here at AnitaB.org are proud of you!