anitab-org / portal

THIS PROJECT IS ARCHIVED. Systers Portal for communities.
GNU General Public License v2.0
68 stars 209 forks source link

Correct the Wiki link on the Navbar #573

Closed sakshi1499 closed 4 years ago

sakshi1499 commented 4 years ago

Description

As a user, I should be able to redirect to the correct wiki.

Mocks

image

Update [Required]

Definition of Done

Estimation

2 hours

Neilblaze commented 4 years ago

@sakshi1499 can you assign me this?

SanketDG commented 4 years ago

@Neilblaze There you go!

sakshi1499 commented 4 years ago

@Neilblaze I hope this is your first time making a PR in Portal. This issue is strictly for first timers. If yes, yay go ahead ☺️

Neilblaze commented 4 years ago

Yes, this is the first time I'm making a PR in Portal.

Neilblaze commented 4 years ago

@sakshi1499 Before I create a PR, I want to review for the final time that the redirection to the correct wiki link is - https://github.com/anitab-org/portal/wiki

Also, there is a documentation mistake in the Systers Portal (https://github.com/anitab-org/portal) in "Setup-for-developers-windows" (https://github.com/anitab-org/portal#setup-for-developers-windows).

The correct method to create a virtual environment with Python 3 and install dependencies, using CMD (on Windows) would be -

$ virtualenv venv
$ .\venv\Scripts\activate
$ pip install -r requirements/dev.txt

instead of

$ virtualenv venv
$ ./venv/Scripts/activate
$ pip install -r requirements/dev.txt
sakshi1499 commented 4 years ago

@Neilblaze Yes. That is the correct link. For the changes in documentation, I think we have an issue for it already created. Ping about the changes you suggest there instead of mentioning it on this issue. ☺️

Neilblaze commented 4 years ago

Cool then 😃 Creating a PR!

Neilblaze commented 4 years ago

@sakshi1499 have a look!

Neilblaze commented 4 years ago

@sakshi1499 please check #577

ritwickraj78 commented 4 years ago

@Neilblaze Approved