Closed sakshi1499 closed 4 years ago
@sakshi1499 can you assign me this?
@Neilblaze There you go!
@Neilblaze I hope this is your first time making a PR in Portal. This issue is strictly for first timers. If yes, yay go ahead ☺️
Yes, this is the first time I'm making a PR in Portal.
@sakshi1499 Before I create a PR, I want to review for the final time that the redirection to the correct wiki link is - https://github.com/anitab-org/portal/wiki
Also, there is a documentation mistake in the Systers Portal (https://github.com/anitab-org/portal) in "Setup-for-developers-windows" (https://github.com/anitab-org/portal#setup-for-developers-windows).
The correct method to create a virtual environment with Python 3 and install dependencies, using CMD (on Windows) would be -
$ virtualenv venv
$ .\venv\Scripts\activate
$ pip install -r requirements/dev.txt
instead of
$ virtualenv venv
$ ./venv/Scripts/activate
$ pip install -r requirements/dev.txt
@Neilblaze Yes. That is the correct link. For the changes in documentation, I think we have an issue for it already created. Ping about the changes you suggest there instead of mentioning it on this issue. ☺️
Cool then 😃 Creating a PR!
@sakshi1499 have a look!
@sakshi1499 please check #577
@Neilblaze Approved
Description
As a user, I should be able to redirect to the correct wiki.
Mocks
Update [Required]
Definition of Done
Estimation
2 hours