Refactor meetup/utils.py

anitab-org / portal

THIS PROJECT IS ARCHIVED. Systers Portal for communities.

GNU General Public License v2.0

68 stars 209 forks source link

Refactor meetup/utils.py #655

Open SanketDG opened 4 years ago

SanketDG commented 4 years ago

Description

A lot of code in meetup/utils.py can be refactored, especially the jwt auth exchange

Definition of Done

[x] All of the required items are completed.
[x] Approval by 1 mentor.

Estimation

3 hours

PragatiVerma18 commented 4 years ago

@SanketDG Can I take this up?

SanketDG commented 4 years ago

@PragatiVerma18 Assigned!

sakshi1499 commented 3 years ago

@PragatiVerma18 Hi Any updates?

tejaswini22199 commented 3 years ago

Hello @SanketDG can I take up the issue!

sakshi1499 commented 3 years ago

Sure! Assigned you @tejaswini22199

tejaswini22199 commented 3 years ago

@sakshi1499 I removed multiple instances of payload and added only one of them. Can you help me in figuring out why it is failing tests while I'm merging.

sakshi1499 commented 3 years ago

There was some issue with the last PR merge maybe that is why. Also, Your PR hasn't followed the commit guidelines so there are failing tests. @tejaswini22199

sankha555 commented 3 years ago

Hello @SanketDG @sakshi1499, I took a look at the PR by @tejaswinii22199 and your comments in that. I understood that we need to create functions for creating tokens and intitialize those tokens at runtime calls. I would like to attempt solving this issue. Could you please assign it to me if it's still open for contribution? Thanks!