anitab-org / portal

THIS PROJECT IS ARCHIVED. Systers Portal for communities.

GNU General Public License v2.0

68 stars 209 forks source link

test: Subscription Tests Added #661

Closed ritwickraj78 closed 4 years ago

ritwickraj78 commented 4 years ago

Description

Tests for the features added.

Fixes #641

Type of Change:

Delete irrelevant options.

Code

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

Checklist:

Delete irrelevant options.

[ ] My PR follows the style guidelines of this project
[ ] I have performed a self-review of my own code or materials
[ ] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] Any dependent changes have been merged

Code/Quality Assurance Only

[ ] My changes generate no new warnings
[ ] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been published in downstream modules

ritwickraj78 commented 4 years ago

@SanketDG I am unable to figure out why one of the tests seem to fail. Could you please check it out?

SanketDG commented 4 years ago

I don't know why but Google-fu says to change https://github.com/anitab-org/portal/blob/8110f63d7c004d73562814620d84f01d1b08a5d0/systers_portal/users/models.py#L196

models.ForeignKey(SystersUser)

sammy1997 commented 4 years ago

@ritwickraj78 can you resolve this? We can merge it then! Let us know if the issue is resolved by what @SanketDG has mentioned

codecov-commenter commented 4 years ago

Codecov Report

Merging #661 into develop will increase coverage by 0.50%. The diff coverage is 79.16%.

@@             Coverage Diff             @@
##           develop     #661      +/-   ##
===========================================
+ Coverage    89.49%   89.99%   +0.50%     
===========================================
  Files           49       49              
  Lines         2693     2699       +6     
===========================================
+ Hits          2410     2429      +19     
+ Misses         283      270      -13

Impacted Files	Coverage Δ
systers_portal/meetup/views.py	`90.26% <70.58%> (+0.01%)`	:arrow_up:
systers_portal/users/models.py	`100.00% <100.00%> (ø)`
systers_portal/users/views.py	`91.13% <100.00%> (+8.70%)`	:arrow_up:
systers_portal/users/forms.py	`92.15% <0.00%> (+13.72%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9aac992...7316ca9. Read the comment docs.

ritwickraj78 commented 4 years ago

@sakshi1499 @SanketDG @sammy1997 Please have a look