anitab-org / portal

THIS PROJECT IS ARCHIVED. Systers Portal for communities.

GNU General Public License v2.0

68 stars 209 forks source link

docs: Update README.md #662

Closed khushishikhu closed 4 years ago

khushishikhu commented 4 years ago

Description Changed in code so that virtual environment can activate correctly.

Fixes #591

Type of Change:

Code
Documentation

Checklist:

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[x] I have made corresponding changes to the documentation

khushishikhu commented 4 years ago

@SanketDG please review my changes.

codecov-commenter commented 4 years ago

Codecov Report

Merging #662 into develop will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #662   +/-   ##
========================================
  Coverage    89.49%   89.49%           
========================================
  Files           49       49           
  Lines         2693     2693           
========================================
  Hits          2410     2410           
  Misses         283      283

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0aa1f2f...91240ca. Read the comment docs.

SanketDG commented 4 years ago

Make sure to follow the commit message guidelines

khushishikhu commented 4 years ago

Make sure to follow the commit message guidelines

yeah sure. Thank you.

SanketDG commented 4 years ago

You will need to change the commit message, not the PR title.

khushishikhu commented 4 years ago

@SanketDG i have changed the commit message style. can you please review it . if it's okay or not now.

khushishikhu commented 4 years ago

@SanketDG Thank you for your approval!!

khushishikhu commented 4 years ago

@saideepesh000 can you please review my changes.

saideepesh000 commented 4 years ago

@saideepesh000 can you please review my changes.

@khushishikhu, thanks for mentioning me, actually I am not the mentor or maintainer of this project, thanks.

SanketDG commented 4 years ago

@saideepesh000

Anyone can review a PR, you can too, it would be of great help!

Whether it's merged or not is upon the maintainers.

khushishikhu commented 4 years ago

@saideepesh000 okay, thank you.

khushishikhu commented 4 years ago

@sammy1997 can you please review my changes.

khushishikhu commented 4 years ago

@sakshi1499 Thank you for your approval !!