Disappearance of home button when Cancel is pressed

anitab-org / powerup-android

PowerUp is an educational choose-your-own-adventure game that utilizes a users uploaded curriculum to empower pre-adolescents to take charge of their reproductive health. This is the Android version of the game.

GNU General Public License v2.0

116 stars 430 forks source link

Disappearance of home button when Cancel is pressed #1006

Closed Rimjhim28 closed 6 years ago

Rimjhim28 commented 6 years ago

Description

As a user, the home button disppears in GameActivity if Cancel from the warning dialog is chosen. I need make changes to function goToMapDialog() so that the home button does not disappear no matter how many times it is cancelled.

Mocks

videotogif_2018 02 18_09 54 28

The button on top right corner disappears after appearance of the dialog.

Acceptance Criteria

Update

[ ] [Changes in goToMap() function]

Definition of Done

[ ] All of the required items are completed.
[ ] Approval by 1 mentor.

Estimation

1 hours

isunitha98selvan commented 6 years ago

I would like to work on this.

Rimjhim28 commented 6 years ago

@isunitha98selvan I have already resolved the issue on my local machine and will be sending a PR once the issue is approved. Please look into some other open issues if available.

Rimjhim28 commented 6 years ago

@m-murad @saurabhjn76 please have a look

m-murad commented 6 years ago

You have sent the PR to the wrong repo.

Rimjhim28 commented 6 years ago

@m-murad I have sent the PR to my own repo since the issue was not approved. Once approved I will send it to systers/powerup

Rimjhim28 commented 6 years ago

@m-murad should I do the changes and send a PR to Systers repo??

m-murad commented 6 years ago

Yes

m-murad commented 6 years ago

Please upload a gif as well

Rimjhim28 commented 6 years ago

@m-murad Done!! :)