Closed nidhinmahesh closed 5 years ago
@nidhinmahesh While the changes look good, could you please post the screenshots of the screens that you have worked on so the we cam be sure that the deletions have not affected anything? Also, add "Fix: " before your commit message so that it is clear that the commit intends to fox a previous issue.
NOTE: Please have a look at the contribution guidelines. Submit a PR only after you are assigned to an issue. We might already have a contributor working on the same, so it's better to ask beforehand. Please take care of this in your future contributions! :)
thank you! I will do it.
@nidhinmahesh I asked to changed the "Commit message" by adding "Fix: ". You can view the commit message in the
commits
tab.
@Rimjhim28 I made the changes you have asked for. Thanks for helping out!
I have squashed the commits. Please check.
@nidhinmahesh I can still see 5 commits on PR. If you are having problem with squashing commits, ask it on slack & someone might help you :)
@geekanamika Thanks.. I fixed it!. @Rimjhim28 please review.
Description
Removed Obsolete attributes (5/5)
Fixes #1102
Type of Change:
removed unused attributes. All screens remains unaffected.
Code/Quality Assurance Only
Checklist:
Delete irrelevant options.
Code/Quality Assurance Only