search

anitab-org / powerup-android

PowerUp is an educational choose-your-own-adventure game that utilizes a users uploaded curriculum to empower pre-adolescents to take charge of their reproductive health. This is the Android version of the game.
GNU General Public License v2.0
117 stars 429 forks source link

Make the app full screen. #1327

Closed moksh-mahajan closed 5 years ago

moksh-mahajan commented 5 years ago

Description

The introductory screen of the app shows the status bar as well. My idea is to make the app should be a full screen app like most of the landscape oriented games are. This will improve the UI to some extent.

Mocks

Present state of the app screenshot_2019-01-25-21-44-05-960_powerup systers com powerup

Acceptance Criteria

Update [Required]

Definition of Done

Estimation

2 hours

honeycoder96 commented 5 years ago

can I work on this issue?

the theme attribute is actually redundant in the manifest file and can be removed and the estimated time is 2 min, not 2 hours.

Rimjhim28 commented 5 years ago

@moksh-mahajan While the issue is valid, there are several screens that can be converted to full screen mode. Coud you please list all the screens on the issue itself first?

Rimjhim28 commented 5 years ago

@honeycoder96 I am not sure if @moksh-mahajan would like to work on the issue itself or pass it on to some other contributor. @moksh-mahajan Are you fine with @honeycoder96 working on the issue and sending a pull request or would you like to fix this by yourself?

honeycoder96 commented 5 years ago

@moksh-mahajan While the issue is valid, there are several screens that can be converted to full screen mode. Coud you please list all the screens on the issue itself first?

I think we can configure the base theme attribute in parent application tag to full screen all the activities and I will wait for @moksh-mahajan before submitting a pr.

moksh-mahajan commented 5 years ago

@honeycoder96 sure go for it. By the way, I'm experiencing this problem on Poco F1.

honeycoder96 commented 5 years ago

@honeycoder96 sure go for it. By the way, I'm experiencing this problem on Poco F1.

Ok i am working on it @Rimjhim28