anitab-org / powerup-android

PowerUp is an educational choose-your-own-adventure game that utilizes a users uploaded curriculum to empower pre-adolescents to take charge of their reproductive health. This is the Android version of the game.
GNU General Public License v2.0
116 stars 430 forks source link

Animation effect is shown when back button is pressed. #1349

Closed moksh-mahajan closed 4 years ago

moksh-mahajan commented 5 years ago

Description

I have included the code for showing the animation efffect while returning from a game or conversation screen to the map screen when back button is pressed. Previously, this effect was only shown when the home icon on the top right corner was pressed.

Fixes #1348

Type of Change:

Code/Quality Assurance Only

How Has This Been Tested?

The app has been built and tested for the implemented feature successfully.

Checklist:

Delete irrelevant options.

Code/Quality Assurance Only

moksh-mahajan commented 5 years ago

@Rimjhim28 @geekanamika Please review this PR.

atm1504 commented 4 years ago

Hey @moksh-mahajan, when u r creating a, pr it's a good habit that you start the Pull request title using words like feat: or chore: or fix: depending on the task you r solving. For example, here you should have started like feat: Add animation on back press Please try to follow this.