anitab-org / powerup-android

PowerUp is an educational choose-your-own-adventure game that utilizes a users uploaded curriculum to empower pre-adolescents to take charge of their reproductive health. This is the Android version of the game.
GNU General Public License v2.0
117 stars 429 forks source link

Fixes issue #1132. Implemented ConstraintLayout #1360

Open devanshi7799 opened 4 years ago

devanshi7799 commented 4 years ago

Description

Implemented ConstraintLayout in gamemap.xml file. Changed FrameLayout to ConstraintLayout Fixes #1132

Type of Change:

Delete irrelevant options.

Code/Quality Assurance Only

How Has This Been Tested?

Tested it on my android phone

Checklist:

Delete irrelevant options.

Code/Quality Assurance Only

devanshi7799 commented 4 years ago

Please review this and tell me what more changes are to be made

sammy1997 commented 4 years ago

@devanshi7799 how is this solving the nesting issue? I think you need to flatten the Layout hierarchy. And it needs to be done for 3 XML files, I can see changes made only to one

therealsanjeev commented 4 years ago

@sammy1997 sir can i work on this issue?

sammy1997 commented 4 years ago

@therealsanjeev The issue has been assigned to @devanshi7799 so she is working on it currently

therealsanjeev commented 4 years ago

@therealsanjeev The issue has been assigned to @devanshi7799 so she is working on it currently

ok sir

devanshi7799 commented 4 years ago

@sammy1997 working on it. Will update my PR soon :))

sammy1997 commented 4 years ago

@devanshi7799 there are 9 commits and many of them are not passing the build. Please squash the commits into 1