search

anitab-org / powerup-android

PowerUp is an educational choose-your-own-adventure game that utilizes a users uploaded curriculum to empower pre-adolescents to take charge of their reproductive health. This is the Android version of the game.
GNU General Public License v2.0
117 stars 429 forks source link

Fixed the Back Pressed #1371

Closed Priyansh-Kedia closed 4 years ago

Priyansh-Kedia commented 4 years ago

Description

The backpressed in MemoryMatchGameActivity is fixed. The app does not crash anymore on back press.

Fixes #1370

Type of Change:

Code/Quality Assurance Only

How Has This Been Tested?

Tested on OnePlus6t

Code/Quality Assurance Only

sammy1997 commented 4 years ago

@Priyansh-Kedia Can you share a screen recording showing that the error is not recurring? You can add the GIF to the PR description body.

sammy1997 commented 4 years ago

The code seems fine to me! Although you should add a more specific exception than a generic one! @geekanamika @Rimjhim28 ?

Priyansh-Kedia commented 4 years ago

@sammy1997 Here is the GIF for the same

WhatsApp Video 2020-03-05 at 8 23 51 PM

sammy1997 commented 4 years ago

@Priyansh-Kedia add it to the PR body(like you did for the issue)

sammy1997 commented 4 years ago

@mayburgos @isabelcosta I think this fixes the issue. Can be merged!

sammy1997 commented 4 years ago

@Priyansh-Kedia Please resend this PR as well