search

anitab-org / powerup-android

PowerUp is an educational choose-your-own-adventure game that utilizes a users uploaded curriculum to empower pre-adolescents to take charge of their reproductive health. This is the Android version of the game.
GNU General Public License v2.0
116 stars 430 forks source link

Time lag on press of home button in AboutActivity #1374

Open Priyansh-Kedia opened 4 years ago

Priyansh-Kedia commented 4 years ago

Description

On the press of home button in AboutActivity, there is a lag of a short time before it opens another acitivty.

Mocks

WhatsApp Video 2020-03-06 at 1 13 45 AM

Acceptance Criteria

Update [Required]

There should be no delay on click of home button

Priyansh-Kedia commented 4 years ago

@sunjunkie @m-murad @isabelcosta May I work on this?

prince-09 commented 4 years ago

can i work on this?

sammy1997 commented 4 years ago

@Priyansh-Kedia I have assigned this to you. But can you discuss a bit about how you want to solve this?

sammy1997 commented 4 years ago

@prince-09 As @Priyansh-Kedia commented first, I have allotted the issue to him

Priyansh-Kedia commented 4 years ago

@Priyansh-Kedia I have assigned this to you. But can you discuss a bit about how you want to solve this?

I will change the click function Currently only finish() is used I will be using finish() along with passing the activity it has to go to.

sammy1997 commented 4 years ago

Ok. Go ahead with the PR!

Priyansh-Kedia commented 4 years ago

Ok. Go ahead with the PR!

Thanks

Priyansh-Kedia commented 4 years ago

@sammy1997 This is the PR https://github.com/anitab-org/powerup-android/pull/1382#issue-385766616 Please review