search

anitab-org / powerup-android

PowerUp is an educational choose-your-own-adventure game that utilizes a users uploaded curriculum to empower pre-adolescents to take charge of their reproductive health. This is the Android version of the game.
GNU General Public License v2.0
116 stars 430 forks source link

Clothes blocking the view of BUY option making UI not good #1389

Open aditmehta9 opened 4 years ago

aditmehta9 commented 4 years ago

Description

As a user, I need to see the BUY option properly, so that I can see clothes and BUY options properly.

Mocks

Screenshot_2020-03-13-13-18-53-889_powerup systers com powerup Screenshot_2020-03-13-13-19-10-082_powerup systers com powerup

Acceptance Criteria

Update [Required]

Definition of Done

Estimation

2 hours

aditmehta9 commented 4 years ago

@mayburgos @isabelcosta @sunjunkie @Rimjhim28 Can I work on this issue?

HaripriyaB commented 4 years ago

Can I work on this as well? @mayburgos @isabelcosta

aditmehta9 commented 4 years ago

Can I work on this as well? @mayburgos @isabelcosta

I have already asked mentors for assigning me this issue. Please ask for another issue.

isabelcosta commented 4 years ago

I am not an active maintainer so I don't know what this takes in terms of complexity, but the issue seems appropriate :) @aditmehta9 I will assign this to you since you haven't had a response for so long. Thank you for waiting for approval.

aditmehta9 commented 4 years ago

@isabelcosta Thanks for assigning. I will start working on it.

aditmehta9 commented 4 years ago

There is a problem while fixing this issue. If I resize the dress then in the store it is fixed but in avatar dress size is inappropriate. So I want to ask should I use the dress displayed in the store one image and another dress image for the avatar. Or there is another approach please guide me, mentors. I am not tagging any mentors currently because lots of mentors are busy right now. Please guide me whenever you are free.

isabelcosta commented 4 years ago

There is a problem while fixing this issue. If I resize the dress then in the store it is fixed but in avatar dress size is inappropriate. So I want to ask should I use the dress displayed in the store one image and another dress image for the avatar. Or there is another approach please guide me, mentors. I am not tagging any mentors currently because lots of mentors are busy right now. Please guide me whenever you are free.

Right now I don't have an answer for this, but I would advise you to reach out to our Zulip community. What do you think?

Priyansh-Kedia commented 4 years ago

There is a problem while fixing this issue. If I resize the dress then in the store it is fixed but in avatar dress size is inappropriate. So I want to ask should I use the dress displayed in the store one image and another dress image for the avatar. Or there is another approach please guide me, mentors. I am not tagging any mentors currently because lots of mentors are busy right now. Please guide me whenever you are free.

I think if you use srcCompat that might fix

Priyansh-Kedia commented 4 years ago

There is a problem while fixing this issue. If I resize the dress then in the store it is fixed but in avatar dress size is inappropriate. So I want to ask should I use the dress displayed in the store one image and another dress image for the avatar. Or there is another approach please guide me, mentors. I am not tagging any mentors currently because lots of mentors are busy right now. Please guide me whenever you are free.

I think if you use srcCompat that might fix

It can be used to auto size the image to fit the dimensions It might help

aditmehta9 commented 4 years ago

There is a problem while fixing this issue. If I resize the dress then in the store it is fixed but in avatar dress size is inappropriate. So I want to ask should I use the dress displayed in the store one image and another dress image for the avatar. Or there is another approach please guide me, mentors. I am not tagging any mentors currently because lots of mentors are busy right now. Please guide me whenever you are free.

Right now I don't have an answer for this, but I would advise you to reach out to our Zulip community. What do you think?

Sure will do

aditmehta9 commented 4 years ago

There is a problem while fixing this issue. If I resize the dress then in the store it is fixed but in avatar dress size is inappropriate. So I want to ask should I use the dress displayed in the store one image and another dress image for the avatar. Or there is another approach please guide me, mentors. I am not tagging any mentors currently because lots of mentors are busy right now. Please guide me whenever you are free.

I think if you use srcCompat that might fix

It can be used to auto size the image to fit the dimensions It might help

Thanks I will do that.

aditmehta9 commented 4 years ago

There is a problem while fixing this issue. If I resize the dress then in the store it is fixed but in avatar dress size is inappropriate. So I want to ask should I use the dress displayed in the store one image and another dress image for the avatar. Or there is another approach please guide me, mentors. I am not tagging any mentors currently because lots of mentors are busy right now. Please guide me whenever you are free.

I think if you use srcCompat that might fix

No, it won't work that way because images aren't called in the XML file. In addition, srcCompat are resize images runtime. Anyways, thanks for the help.

Priyansh-Kedia commented 4 years ago

There is a problem while fixing this issue. If I resize the dress then in the store it is fixed but in avatar dress size is inappropriate. So I want to ask should I use the dress displayed in the store one image and another dress image for the avatar. Or there is another approach please guide me, mentors. I am not tagging any mentors currently because lots of mentors are busy right now. Please guide me whenever you are free.

I think if you use srcCompat that might fix

No, it won't work that way because images aren't called in the XML file. In addition, srcCompat are resize images runtime. Anyways, thanks for the help.

What do you mean by calling XML Files?

aditmehta9 commented 4 years ago

There is a problem while fixing this issue. If I resize the dress then in the store it is fixed but in avatar dress size is inappropriate. So I want to ask should I use the dress displayed in the store one image and another dress image for the avatar. Or there is another approach please guide me, mentors. I am not tagging any mentors currently because lots of mentors are busy right now. Please guide me whenever you are free.

I think if you use srcCompat that might fix

No, it won't work that way because images aren't called in the XML file. In addition, srcCompat are resize images runtime. Anyways, thanks for the help.

What do you mean by calling XML Files?

Layout files

Priyansh-Kedia commented 4 years ago

There is a problem while fixing this issue. If I resize the dress then in the store it is fixed but in avatar dress size is inappropriate. So I want to ask should I use the dress displayed in the store one image and another dress image for the avatar. Or there is another approach please guide me, mentors. I am not tagging any mentors currently because lots of mentors are busy right now. Please guide me whenever you are free.

I think if you use srcCompat that might fix

No, it won't work that way because images aren't called in the XML file. In addition, srcCompat are resize images runtime. Anyways, thanks for the help.

What do you mean by calling XML Files?

Layout files

Yes the images are fetched in the XML files, but they are rendered into the XML only. All you could do is change the particular card in which the images are being rendered.

aditmehta9 commented 4 years ago

There is a problem while fixing this issue. If I resize the dress then in the store it is fixed but in avatar dress size is inappropriate. So I want to ask should I use the dress displayed in the store one image and another dress image for the avatar. Or there is another approach please guide me, mentors. I am not tagging any mentors currently because lots of mentors are busy right now. Please guide me whenever you are free.

I think if you use srcCompat that might fix

No, it won't work that way because images aren't called in the XML file. In addition, srcCompat are resize images runtime. Anyways, thanks for the help.

What do you mean by calling XML Files?

Layout files

Yes the images are fetched in the XML files, but they are rendered into the XML only. All you could do is change the particular card in which the images are being rendered.

Yes, I will see it.

HaripriyaB commented 4 years ago

Is this issue solved or yet to be solve? @aditmehta9

aditmehta9 commented 4 years ago

No @HaripriyaB , I am not working on this issue I am trying to work on another issue. Sorry for the inconvenience. I have assigned it to you because you had commented after me.

HaripriyaB commented 4 years ago

No @HaripriyaB , I am not working on this issue I am trying to work on another issue. Sorry for the inconvenience. I have assigned it to you because you had commented after me.

Yup no problem I'll handle it.

HaripriyaB commented 4 years ago

I think this issue is no more. I pulled the repo and installed the app and this is what I see. May be the issue is resolved already. @aditmehta9 pls review it. Screenshot_2020-05-04-12-38-50-02_edd379f413d28fd43f4496fab0e55864

aditmehta9 commented 4 years ago

I think this issue is no more. I pulled the repo and installed the app and this is what I see. May be the issue is resolved already. @aditmehta9 pls review it. Screenshot_2020-05-04-12-38-50-02_edd379f413d28fd43f4496fab0e55864

No, the problem still persists. Level 1 images were ok. It was problem for level to avatar shop. Please check level 2 avatar shop @HaripriyaB

HaripriyaB commented 4 years ago

Yes @aditmehta9 The problem is in the level 2 of the game. So I'll work on it. Screenshot_2020-05-04-12-56-17-88_edd379f413d28fd43f4496fab0e55864