anitab-org / powerup-android

PowerUp is an educational choose-your-own-adventure game that utilizes a users uploaded curriculum to empower pre-adolescents to take charge of their reproductive health. This is the Android version of the game.
GNU General Public License v2.0
117 stars 429 forks source link

Fixes issue #697. Text is now visible properly in vocab match game #1390

Open devanshi7799 opened 4 years ago

devanshi7799 commented 4 years ago

Description

I have made changes in the activity_vocab_match_game.xml file. I have simply added padding value to keep the text at the centre of the image

Fixes #697

Type of Change:

Delete irrelevant options.

Code/Quality Assurance Only

How Has This Been Tested?

I have tested this on two android devices(vivo y51l and micromax HS2) and it works perfectly fine

Checklist:

Delete irrelevant options.

Code/Quality Assurance Only

75097340-aac74a00-55cf-11ea-9ac4-8d283679d5e2 75097339-a864f000-55cf-11ea-9ed3-1f9597a2fa04

devanshi7799 commented 4 years ago

@Priyansh-Kedia Oh , I might have misspelled it. Thanks for pointing it out :)

Priyansh-Kedia commented 4 years ago

@Priyansh-Kedia Oh , I might have misspelled it. Thanks for pointing it out :)

Happy to help

sammy1997 commented 4 years ago

@devanshi7799 Please squash the commits. I can see 5 commits in the PR

devanshi7799 commented 4 years ago

@sammy i will make the necessary changes and upadate the PR soon :))

devanshi7799 commented 4 years ago

@sammy1997 I have squashed the commits. Can you please review it?

sammy1997 commented 4 years ago

I can still see that the text is coming out of the pad. Wrapping the text or auto-resizing would be a better way to solve this. Can you try that @devanshi7799 ?

devanshi7799 commented 4 years ago

@sammy1997 Yes sure! I Will solve it and get back to you