anitab-org / powerup-android

PowerUp is an educational choose-your-own-adventure game that utilizes a users uploaded curriculum to empower pre-adolescents to take charge of their reproductive health. This is the Android version of the game.
GNU General Public License v2.0
117 stars 429 forks source link

When presses replay button karma points addition isn't correct and adds power karma points #1394

Open aditmehta9 opened 4 years ago

aditmehta9 commented 4 years ago

Description

As a user, I need to reset karma points count properly so that I can use karma points correctly.

Mocks

ezgif com-video-to-gif

Acceptance Criteria

Update [Required]

Definition of Done

Estimation

4 hours

aditmehta9 commented 4 years ago

@sunjunkie @Rimjhim28 @isabelcosta @mayburgos Can I work on this issue?

sammy1997 commented 4 years ago

Approving the issue, but as you are already assigned to 2 issues, I am making this available for others.

vold-la commented 4 years ago

@sammy1997 Can i work on this?

HaripriyaB commented 4 years ago

Can I work on this pls? I haven't got a chance yet. @sammy1997 @mayburgos @sunjunkie

robotjellyzone commented 4 years ago

Hi @HaripriyaB , if you are a first time contributor here then please take a look at the issues with labels First Timer Only and only those not assigned yet .

HaripriyaB commented 4 years ago

@robotjellyzone yes I'm a first timer and wish to work on this project. I'll look in to the first timer tag. Thanks!

sammy1997 commented 4 years ago

@vold-la go ahead

vold-la commented 4 years ago

I think this not not an issue but a mere confusion to understand the game. First the dialog box at the end does not show addition of power points since power points earned are directly added to total points which acts as bonus in the game. Secondly if we press replay button then karma points(only earned by giving answers) earned from previous play are deducted. Let us take example, you are having 20 points and you played a scenario and earned 6 points so your total becomes 26. Now you replay the scenario so 6 points get deducted so your total becomes 20, then you earned 20 power points and 6 points by giving response. so again total becomes 46. So to avoid this confusion we can prompt dialog informing "if you replay your previous point will get deducted" and add in current dialog of power points that power points will be added to total points. what do you think? is this correct? should i open other issue to add dialog? @sammy1997 @aditmehta9

aditmehta9 commented 4 years ago

I think this not not an issue but a mere confusion to understand the game. First the dialog box at the end does not show addition of power points since power points earned are directly added to total points which acts as bonus in the game. Secondly if we press replay button then karma points(only earned by giving answers) earned from previous play are deducted. Let us take example, you are having 20 points and you played a scenario and earned 6 points so your total becomes 26. Now you replay the scenario so 6 points get deducted so your total becomes 20, then you earned 20 power points and 6 points by giving response. so again total becomes 46. So to avoid this confusion we can prompt dialog informing "if you replay your previous point will get deducted" and add in current dialog of power points that power points will be added to total points. what do you think? is this correct? should i open other issue to add dialog? @sammy1997 @aditmehta9

Yeah, that is right but I also wanted to show the addition of points gained by powers to show in a dialog box. But according to your logic if a user plays level 1 scenario 3 hospital and after playing that scenario his total points are 34 and in the next scenario, he clicks on the home button without playing scenario 4(library) and replays scenario 1(home) then new points are added without deduction of previous points and the total becomes 44. However, which should not happen according to your logic and deduct points of playing that scenario when it was played earlier.

aditmehta9 commented 4 years ago

So, I think there should be a change in the game logic for all scenarios replay or last played scenario.

vold-la commented 4 years ago

totally agree that points section needs to be organized. We should discuss this with mentors in zulip.

aditmehta9 commented 4 years ago

totally agree that points section needs to be organized. We should discuss this with mentors in zulip.

Yep