search

anitab-org / powerup-android

PowerUp is an educational choose-your-own-adventure game that utilizes a users uploaded curriculum to empower pre-adolescents to take charge of their reproductive health. This is the Android version of the game.
GNU General Public License v2.0
117 stars 429 forks source link

Re: Karma points do not add if Ok is not pressed after full power #1418

Open Priyansh-Kedia opened 4 years ago

Priyansh-Kedia commented 4 years ago

Description

The Karma points add up even when the dialog box is cancelled.

Fixes #1414

Type of Change:

Code/Quality Assurance Only

How Has This Been Tested?

Tested on OnePlus6t

vold-la commented 4 years ago

@Priyansh-Kedia try increasing SessionHistory.currScenePoints also in CancelListener ,so that current point also increases :)

Priyansh-Kedia commented 4 years ago

@Priyansh-Kedia try increasing SessionHistory.currScenePoints also in CancelListener ,so that current point also increases :)

Hello @vold-la The thing is, the current application just adds 5 points in the total points (Session History) on click of the OK button. As this issue was focused on solving the problem related to the OK button, I think I should only add the points to total points on cancel of the dialog box.

Also, these powers are shown to fetch points in the complete game and hence I think these points should be added to the total game points only. What do you think? I would be happy to open a separate issue regarding this if you think that this should be implemented as we would have to change some code for the press of OK button too which is out of the scope of this issue.

Thanks