search

anitab-org / powerup-android

PowerUp is an educational choose-your-own-adventure game that utilizes a users uploaded curriculum to empower pre-adolescents to take charge of their reproductive health. This is the Android version of the game.
GNU General Public License v2.0
117 stars 429 forks source link

Remove inconsistency between home and back button #996

Closed Rimjhim28 closed 6 years ago

Rimjhim28 commented 6 years ago

Description

If the home button is pressed in the middle of the scenario, the user is first presented with a warning dialog. The user can either choose to go to map or dismiss the dialog. If the back button is pressed, the user is directed to map at once without any warning. It would be better option to implement similar dialog for back button as well.

Mocks

The warning dialog presented if home button clicked: screenshot_2018-02-14-02-53-15-635_powerup systers com powerup

Acceptance Criteria

Update

Definition of Done

Estimation

30 minutes.

I would like to work on the issue

raghavpuri31 commented 6 years ago

So I set up the project in Android Studio and build an apk but found that apparently no dialogue box appears when home button is pressed in the middle of scenario @Rimjhim28 !

Rimjhim28 commented 6 years ago

@raghavpuri31 Please be sure that you are on the GSoC17 branch. The latest code updates have been done there. As implemented by one of our GCI participant, the dialog box would only appear if you have answered atleast one time and scored some points, since it would be completely illogical to make a warning of loosing total points until the user has actually scored some points.

videotogif_2018 02 18_09 51 59

Rimjhim28 commented 6 years ago

@m-murad please approve the issue.

m-murad commented 6 years ago

This is a valid issue. Please fix this.

Rimjhim28 commented 6 years ago

@m-murad Thanks for the approval. Will be sending the PR soon!!