anitab-org / powerup-android

PowerUp is an educational choose-your-own-adventure game that utilizes a users uploaded curriculum to empower pre-adolescents to take charge of their reproductive health. This is the Android version of the game.
GNU General Public License v2.0
116 stars 430 forks source link

Rectify the implementation of warning dialog in store #998

Closed Rimjhim28 closed 6 years ago

Rimjhim28 commented 6 years ago

Description

With recent changes in the code, a warning dialog is implemented to warn the user prior to buying an item. The item gets already set on avatar before user's decision whether it should be bought or not. A rectification is needed here such that, clicking on the item first presents the dialog and only if the userconfirms, the item is bought.

Mocks

videotogif_2018 02 14_13 03 58

Acceptance Criteria

Update

Definition of Done

Estimation

1 hour

I would like to work on the issue

shivanshsoni commented 6 years ago

@Rimjhim28 Are you working on this??

shivanshsoni commented 6 years ago

@Rimjhim28 I have solved this issue So, Can I make the pull request.

Rimjhim28 commented 6 years ago

@shivanshsoni it's mentioned on the issue itself that I am working on it. Please look into some other available issue.

Rimjhim28 commented 6 years ago

@m-murad @saurabhjn76 please have a look

m-murad commented 6 years ago

valid issue. please send PR