anitab-org / stem-diverse-tv-cms

CMS for managing content of STEM Diverse TV
https://anitab-org.github.io/stem-diverse-tv-cms/
GNU General Public License v3.0
4 stars 22 forks source link

Bug: Register form not completely visible #30

Open Rahulm2310 opened 3 years ago

Rahulm2310 commented 3 years ago

Describe the bug

The register UI is not completely visible on laptop screen size and not scrollable. Also, the alerts are not completely visible and just shows up for merely 1 second.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://anitab-org.github.io/stem-diverse-tv-cms/
  2. Click on 'register'
  3. See error

Expected behavior

The page should be scrollable and alerts should remain for more time like 2-3 seconds or more.

Screenshots

register-ui-issue

Desktop (please complete the following information):

Rahulm2310 commented 3 years ago

@annabauza Can you please confirm/approve this issue. This can be a good first timer issue.

chinmaym07 commented 3 years ago

@Rahulm2310 have you tested these locally .? Also the error that displays for a second that's not a error that's a confirmation that password matched & It should go like that , it occurs on the hosted because we are not getting back the correct response from the backend. Try this locally you will get it . The errors are shown in red & confirmation is shown in blue .

Peek 2021-02-13 14-36 Register UI is completely visible .Can you please exactly point where the error is.? Also thanks for testing this πŸ‘πŸ» πŸ˜€ Locally it works like this Peek 2021-02-09 20-41

Rahulm2310 commented 3 years ago

@chinmaym07 On my 14-inches screen, I face the issue and have added the GIF for the same. May be you possess a larger display.

Also the error that displays for a second that's not a error that's a confirmation that password matched

I mentioned alert and not error. I think the message even if a confirmation should stay at least for 2 seconds. Otherwise there is no point displaying them.

chinmaym07 commented 3 years ago

@Rahulm2310 It just a sign of notifying the user that he had entered correct credentials & in last GIF that I posted it stays there for more than 2-3 seconds & the GIF you posted above looks blurred to me sorry I am unable to find where the issue is with displaying of Registeration form. Please check it once more , If you still face this issue of bad visibility of Registeration form.

annabauza commented 3 years ago

approved. I don't think it's first timer issue.

jalajcodes commented 3 years ago

@annabauza Can I work on it?

annabauza commented 3 years ago

@jalajcodes yours

jalajcodes commented 3 years ago

@Rahulm2310 Does @chinmaym07 reply resolves your problem about error not staying long enough?

In your case, the error stays for just a fraction because the request never gets sent to the correct url. This should be fixed soon.

jalajcodes commented 3 years ago

I think its not necessary to show a confirmation when passwords match... instead, it should check if they don't match and then show the error and return from the function so the request doesn't get sent.

Rahulm2310 commented 3 years ago

@jalajcodes Are you working on this. If not started, you can make it available for OSH.

jalajcodes commented 3 years ago

@Rahulm2310 yeah that's what I want to do, just waiting to get access to label issues in this repoπŸ˜‰

Rahulm2310 commented 3 years ago

@jalajcodes unassigning you and opening this for OSH aspirants πŸ˜‰

nlok5923 commented 3 years ago

@Rahulm2310 can i take up this issue.