anitab-org / stem-diverse-tv-cms

CMS for managing content of STEM Diverse TV
https://anitab-org.github.io/stem-diverse-tv-cms/
GNU General Public License v3.0
4 stars 22 forks source link

Bug: terms & conditions checkbox should be 'required' on register form #49

Open Rahulm2310 opened 3 years ago

Rahulm2310 commented 3 years ago

Describe the bug

User is allowed to submit register form without accepting the terms and conditions.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://anitab-org.github.io/stem-diverse-tv-cms/register
  2. Enter user details
  3. Let the checkbox for terms and conditions unchecked.
  4. See error

Expected behavior

User should be prompted to accept the terms and conditions (add required prop to the checkbox).

Screenshots

stem-checkbox

Desktop (please complete the following information):

VenomFate-619 commented 3 years ago

can I fix it?

isabelcosta commented 3 years ago

@VenomFate-619 sure! I will assign this to you :)

VenomFate-619 commented 3 years ago

It is seen to be already fixed . it is working correctly both on live site and locally Code for reference <Checkbox color="primary" name="termsAndConditionChecked" onChange={() => setTermsAndConditions(!termsAndConditionChecked)} required />

On production website :- image On developing website :- image

VenomFate-619 commented 3 years ago

A new bug is created, although I clicked the checkbox but also the error message is displayed.

image

ss from the network tab

image

I think the error is from frontend it is not sending proper property value for that purpose

isabelcosta commented 3 years ago

@VenomFate-619 would you like to create an issue for this error you mentioned?

VenomFate-619 commented 3 years ago

Yes, I would like to. I had created a new error , can you assign it to me #71