feat: Added GitHub Actions

anshsrtv commented 3 years ago

Description

Two GitHub workflows for linting and running tests have been added.

Fixes #220

Type of Change:

Quality Assurance
Documentation

Code/Quality Assurance Only

New feature (non-breaking change which adds functionality pre-approved by mentors)

Checklist:

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[ ] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] Any dependent changes have been merged

Code/Quality Assurance Only

[x] My changes generate no new warnings
[ ] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been published in downstream modules

anshsrtv commented 3 years ago

@anshsrtv you shouldn't make a PR from default branch(master in this case).

Thanks for pointing that out! I realized it later, after making the PR. Really sorry, this won't happen again.

epicadk commented 3 years ago

Thanks. Looks good. As a suggestion, you could have just run the command make docker_test so that the tests would run inside the docker container. This works too.

devkapilbansal commented 3 years ago

This PR is from the master branch which is against this. I think you need to change the base branch @anshsrtv

@codesankalp no problem. Changinig base branch will require this PR to be closed that is not necessary. I already quoted this above https://github.com/anitab-org/stem-diverse-tv/pull/221#issuecomment-819337184

Amulya-coder commented 3 years ago

@codesankalp @devkapilbansal actually the base branch which is currently using is also going to be changed with develop instead of master, but develop is not updated from a long time so master is used, this was recently discussed during this issue.

devkapilbansal commented 3 years ago

Actually, it is advisable not to create a branch with default name because it makes it hard to pull locally and test. Rest everything is fine

devkapilbansal commented 3 years ago

Adding Ready to Merge because build passed successfully ensuring the workflow is correct

Amulya-coder commented 3 years ago

@anshsrtv can you please do the required changes mentioned above?

epicadk commented 3 years ago

@annabauza seems like the contributor is inactive. I think we can merge the pr and then open new issues for the required changes.

epicadk commented 3 years ago

Closing due to inactivity (discussed in the open session). Thankyou for the pr @anshsrtv

anitab-org / stem-diverse-tv