Closed divyanshugit closed 2 years ago
@divyanshugit can you add a screenshot of your work in the PR description
Previously
After Update
@mayburgos , @yashshah2820 can you review once !
@divyanshugit can you please add to the PR description how the logo will look like now on the website with your change?
@isabelcosta I have already added that you can preview it https://github.com/anitab-org/vms/pull/1000#issuecomment-664002403
@divyanshugit, can you pls update the branch from where you sent the PR. It's most preferable to not send PRs from develop too, it's fine for now, but next time onwards do send from a branch different from develop.
@gaurivn Okay, I will keep this in my mind from the next time onwards. Thanks for the advice.
Merging #1000 into develop will increase coverage by
0.24%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## develop #1000 +/- ##
===========================================
+ Coverage 86.93% 87.18% +0.24%
===========================================
Files 85 85
Lines 4057 4057
Branches 237 237
===========================================
+ Hits 3527 3537 +10
+ Misses 458 449 -9
+ Partials 72 71 -1
Impacted Files | Coverage Δ | |
---|---|---|
vms/shift/views.py | 63.40% <0.00%> (+2.00%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 0ab16d3...0d3837b. Read the comment docs.
@devkapilbansal solved in another issue? If that is the case, could you please link it in a comment here. If you mean, merge this, let me know and I can proceed with merging.
@devkapilbansal solved in another issue? If that is the case, could you please link it in a comment here. If you mean, merge this, let me know and I can proceed with merging.
Sorry my bad. Commented on wrong issue
Description Deleted previous logo and added a new logo for Volunteer Management System
Fixes #982
Type of Change:
Checklist
[x] Removed Systers logo
[x] My changes generate no new warnings