Add button in UI to link Zulip

anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.

GNU General Public License v2.0

1 stars 4 forks source link

Add button in UI to link Zulip #1038

Closed keshakaneria closed 4 years ago

keshakaneria commented 4 years ago

Description

As a user, I need to add a button to link our Zulip communication platform, so that I can have smooth communication through project.

Acceptance Criteria

Update [Required]

[ ] Screen shot in PR to show Button added
[ ] Link to organisation group, Zulip

Definition of Done

[ ] All of the required items are completed.
[ ] Approval by 1 mentor.

Estimation

2 hours

keshakaneria commented 4 years ago

@khushishikhu Glad that you are interested in this issue. This issue is for Open Source Hack which will start from 1st September. You are requested to wait until the event gets started to create PRs. Once it gets started, I will assign it to you :)

vaibhavarora102 commented 4 years ago

@keshakaneria can anyone work on this or you are going to give this to above profile who asked first thanks

keshakaneria commented 4 years ago

@vaibhavarora102 Yes it will be assigned to the person who comes first to work on the issue. If he/she is inactive for 3 days, the next interested person will be assigned for the same.

vaibhavarora102 commented 4 years ago

okay thanks

chaudhariyash10 commented 4 years ago

Will the issue be assigned to many students or will be only one person working on one issue?

yash2189 commented 4 years ago

Can I work on this @keshakaneria?

vaibhavarora102 commented 4 years ago

Hi, can you pls assign this issue to me as its already 1st of September and I guess OSH has started Thanks

keshakaneria commented 4 years ago

@vaibhavarora102 @khushishikhu It seems you have been assigned one issue already to work on. So the other person will be assigned who came first.

yash2189 commented 4 years ago

Is this issue available to work on @keshakaneria?

keshakaneria commented 4 years ago

@yash2189 If there is three days of inactivity by the assigned person, I will assign it to you

yash2189 commented 4 years ago

Can I work on this @keshakaneria ? Just mentioned because there was no pull request done for this yet.

keshakaneria commented 4 years ago

@yash2189 Go for it :)

vaibhavarora102 commented 4 years ago

next time pls assign to me

keshakaneria commented 4 years ago

next time pls assign to me

I saw you were assigned some issue. If you won't be assigned with any next time, will surely assign you your interested issue to work on 👍

vaibhavarora102 commented 4 years ago

I had done all my work just merging is left

yash2189 commented 4 years ago

@keshakaneria I have setup the project completely on my system. I wanted to ask whether the button has to be added on homepage i.e home.html?

keshakaneria commented 4 years ago

@keshakaneria I have setup the project completely on my system. I wanted to ask whether the button has to be added on homepage i.e home.html?

Yes, once the user is logged in, there should be a button which links to the Zulip channels

yash2189 commented 4 years ago

@keshakaneria You mean this link correct http://anitab-org.zulipchat.com?

keshakaneria commented 4 years ago

@yash2189 Yes

yash2189 commented 4 years ago

@keshakaneria Please review my PR . Why is it showing 1 check failed?

yash2189 commented 4 years ago

@keshakaneria Please review my new PR #1089 for this issue.

yash2189 commented 4 years ago

@keshakaneria I have made the required changes for PR #1089

yash2189 commented 4 years ago

@keshakaneria please review the PR again.