[Bug] Features for volunteer not visible for users having organisation other than the listed ones

anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.

GNU General Public License v2.0

1 stars 4 forks source link

[Bug] Features for volunteer not visible for users having organisation other than the listed ones #1042

Open Kajol-Kumari opened 4 years ago

Kajol-Kumari commented 4 years ago

Description

Currently, we have none of the volunteer features available if we signup with an organisation other than the listed ones.

Mocks

imageedit_2_9999273369

Acceptance Criteria

Update

[ ] Fix this bug so that all the normal users should be able to avail the volunteer features and privileges.

Definition of Done

[ ] All of the required items are completed.
[ ] Approval by 1 mentor.

Estimation

2 hours

decon-harsh commented 4 years ago

Hey I am new in this community and I am participating in OSH can I take this up?

raksh543 commented 4 years ago

I am willing to work on this issue

Kajol-Kumari commented 4 years ago

Hey @decon-harsh please go ahead with this issue :+1: @raksh543 as we need to follow FCFS so can't assign this to you. Feel free to take up any other issue.

decon-harsh commented 4 years ago

Hey @Kajol-Kumari I think there are options for the above mentioned issue..

Screenshots

Screenshot from 2020-09-01 10-55-44

Screenshot from 2020-09-01 10-58-19

Screenshot from 2020-09-01 10-58-24

I am sorry If I misunderstood anything! First Timer here!

Kajol-Kumari commented 4 years ago

Hey @decon-harsh let me check this on my local. 'coz last time I had ran this on my local, I was not able to view anything except logout.

decon-harsh commented 4 years ago

Just a request can you check it asap, cause I won't be assigned on multiple issues at once.

Kajol-Kumari commented 4 years ago

Wierd! I am still not able to see these options on my local @gaurivn @keshakaneria can anyone of you please confirm If you are able to access these features when logged in as normal user on your local.

@decon-harsh I am Unassigning you for now so that you can take other issue. Please go ahead with another issue for now till we get it cleared.

decon-harsh commented 4 years ago

Hey @Kajol-Kumari , During signup whenever I entered a non-unique organisation or left it blank then it showed an error screen .

Screenshot from 2020-09-02 02-49-56

And then if we try to login with that user it takes us to the screen mentioned in the issue.

Screenshot from 2020-09-02 02-50-15

I guess the term normal user means as a volunteer?

I think if only a User instance is made and it is not declared an admin or volunteer then this happens.

keshakaneria commented 4 years ago

@Kajol-Kumari will check once locally and let you know

Kajol-Kumari commented 4 years ago

Hey @decon-harsh Thanks for pointing this. Yes, the normal user is a volunteer. This is a bug and this was the same thing I was encountering. I am modifying the issue description accordingly to make the goal of this issue more clear.

decon-harsh commented 4 years ago

I would love to work on this..

I solved this issue locally .. Actually the unlisted_organization does create instead of get_or_create.

I think this will solve.

Can you assign me this again?

Kajol-Kumari commented 4 years ago

Hey @decon-harsh as you have opened the PR for the previous assigned issue, you can go ahead with this one :)

decon-harsh commented 4 years ago

Kindly review this.