anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.
GNU General Public License v2.0
1 stars 4 forks source link

UI: Change behavior of address fields in volunteer and admin sign-up #1050

Open rkpattnaik780 opened 4 years ago

rkpattnaik780 commented 4 years ago

Description

As a volunteer/admin, while signing up, the form fields pertaining to address should be enabled only if the dependent fields are filled. The "state/province" field should be enabled only after country is selected. City should be enabled only if both "country" and "state/province" are selected.

Acceptance Criteria

Update [Required]

Definition of Done

Estimation

2 hours

ymaheshwari1 commented 4 years ago

I am interested in working on this.

abhinav72610 commented 4 years ago

@rkpattnaik780 Hey I am new in this community and I am participating in OSH can I take this up?

yash2189 commented 4 years ago

Can I work on this @rkpattnaik780 ?

PrernaSingh587 commented 4 years ago

Hi, I am interested to work on this. Can I do it?

rkpattnaik780 commented 4 years ago

Hi, I am interested to work on this. Can I do it?

@psingh587 go ahead!

PrernaSingh587 commented 4 years ago

Sure, Thanks!

rkpattnaik780 commented 4 years ago

@psingh587 are you still working on this issue?

PrernaSingh587 commented 4 years ago

Sir, I am having problems in installation of VMS in my machine. I had asked for help yesterday but no response yet. Could you please help me? I have checked the files on the repo, i can fix this, only problem is the installation.

rkpattnaik780 commented 4 years ago

Let me try to run vms using docker compose, I will reach back after that.

PrernaSingh587 commented 4 years ago

My Installation is done. I am working on this. Thanks so much for your help

PrernaSingh587 commented 4 years ago

Sir, I have a question. Screenshot from 2020-09-05 18-21-53

This is what I see in volunteer sign up page. In this, City is there first, then state, then country. But in live vms, its different. Screenshot from 2020-09-05 18-24-36

Here its written in order. Where am I going wrong? Also, there is no dropdown for city, country as well. another issue has already been raised on it.

PrernaSingh587 commented 4 years ago

@rkpattnaik780 Anything on it?

rkpattnaik780 commented 4 years ago

@psingh587 sorry for the delayed response. I can see the change can be done only to admin signup page, you just need to disable the respective dropdowns with something like <select disabled>. You have to conditionally put the disabled attribute.

PrernaSingh587 commented 4 years ago

Okay so that means I only have to do it in the admin sign up page right? I have written a JS function and its working as well. I will attach it. I have written that function in another JS file which was already there containing other function. Should I make a new file? or Will it be okay if I write it in this one? Also , when I am trying to make another file , I cant see the change I made. How shall I proceed? WhatsApp-Video-2020-09-06-at-173

rkpattnaik780 commented 4 years ago

Hello @psingh587 . Yup just the admin signup. I was thinking this wouldn't be needing a JS file. You can conditionally add an attribute to the template. I googled it right now, you can do something like this. And this is bit out of context, to easily record screen, use peek :)

PrernaSingh587 commented 4 years ago

Hello @psingh587 . Yup just the admin signup. I was thinking this wouldn't be needing a JS file. You can conditionally add an attribute to the template. I googled it right now, you can do something like this. And this is bit out of context, to easily record screen, use peek :)

Hi, Actually I had thought about it earlier- to do it inside the HTML only. But I am not able to figure out how to write the condition to disable=" " . How to get the value of country dynamically? Please help me here. I checked it here as well

rkpattnaik780 commented 4 years ago

Hello @psingh587 . Yup just the admin signup. I was thinking this wouldn't be needing a JS file. You can conditionally add an attribute to the template. I googled it right now, you can do something like this. And this is bit out of context, to easily record screen, use peek :)

Hi, Actually I had thought about it earlier- to do it inside the HTML only. But I am not able to figure out how to write the condition to disable=" " . How to get the value of country dynamically? Please help me here. I checked it here as well

It seems bit tricky to do it in htmll. You can handle it through javascript, won't be an issue. Just handle all the scenarios.

rkpattnaik780 commented 4 years ago

There is no necessity to create a new js file, load_city.js and load_state.js should do the work.

PrernaSingh587 commented 4 years ago

There is no necessity to create a new js file, load_city.js and load_state.js should do the work.

Working on it!

PrernaSingh587 commented 4 years ago

@rkpattnaik780 Please look into my PR