anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.

GNU General Public License v2.0

1 stars 4 forks source link

docs: add a python version badge (#1052) #1054

Closed aniketrb-github closed 4 years ago

aniketrb-github commented 4 years ago

Description

Added a python version badge

Fixes #1052

Mock

anitab-org-vms-fix1052

Type of Change:

Documentation

Checklist:

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[ ] I have commented on my code or provided relevant documentation, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[ ] Any dependent changes have been merged

rkpattnaik780 commented 4 years ago

Hello @aniketrb-github . Thanks for showing interest in this project. I just wanted to know if you are an OSH participant.

aniketrb-github commented 4 years ago

Hello @aniketrb-github . Thanks for showing interest in this project. I just wanted to know if you are an OSH participant.

@rkpattnaik780 No, as of now I'm not a participant of the OSH event. If the registration is mandatory and if it restricts me from contributing, can you please guide me or direct me towards the same. Thanks.

aniketrb-github commented 4 years ago

The second commit fixes Issue #1047, not this one, pls undo the change.

Yes, I have mistakenly clubbed it in this PR. Should I create a separate PR with only code changes related #1057...?

gaurivn commented 4 years ago

@aniketrb-github, would be better to work on an issue after it is assigned to you.

gaurivn commented 4 years ago

The second commit fixes Issue #1047, not this one, pls undo the change.

Yes, I have mistakenly clubbed it in this PR. Should I create a separate PR with only code changes related #1057...?

No, you only have to undo the second commit, undo the changes you made in the second commit.

aniketrb-github commented 4 years ago

The second commit fixes Issue #1047, not this one, pls undo the change.

Yes, I have mistakenly clubbed it in this PR. Should I create a separate PR with only code changes related #1057...?

No, you only have to undo the second commit, undo the changes you made in the second commit.

Ok got it. Yes, I won't raise a new PR with the corrected changes and will rather wait until it's assigned to me. Thanks.

rkpattnaik780 commented 4 years ago

Hello @aniketrb-github . I am closing this PR since it does not comply with the guidelines. Feel free to comment on the issue again after 00:00 IST. Issues will be assigned on first come first serve basis. You can raise a PR only after an issue has been assigned.

aniketrb-github commented 4 years ago

Hello @aniketrb-github . I am closing this PR since it does not comply with the guidelines. Feel free to comment on the issue again after 00:00 IST. Issues will be assigned on first come first serve basis. You can raise a PR only after an issue has been assigned.

Sure @rkpattnaik780. Thanks.