search

anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.
GNU General Public License v2.0
1 stars 4 forks source link

made contributors.md #1059

Closed vaibhavarora102 closed 4 years ago

vaibhavarora102 commented 4 years ago

Description

added the contributors.md file and installed all-contributors bot as a part of the open-source hack Fixes #1028

Type of Change:

Delete irrelevant options.

How Has This Been Tested?

just added a readme file

Checklist:

Delete irrelevant options.

Kajol-Kumari commented 4 years ago

Hey @vaibhavarora102 thanks for the PR but I think this bot won't work untill we provide it the read and write access of the vms main repo. So, I am currently looking for a way to implement it. Meanwhile you can work on the other issue.

vaibhavarora102 commented 4 years ago

Oh thanks for information

vaibhavarora102 commented 4 years ago

Can you pls tell the format in which I had to write

Kajol-Kumari commented 4 years ago

Can you pls tell the format in which I had to write

@vaibhavarora102 keep it in tabular form having details like contributor's name, their github profile link and the number of commits they have made.

vaibhavarora102 commented 4 years ago

Should I close this pr and add another one?

Kajol-Kumari commented 4 years ago

Should I close this pr and add another one?

You can make the required changes in this PR only. No need of opening up a new one.

vaibhavarora102 commented 4 years ago

okay

vaibhavarora102 commented 4 years ago

hi @Kajol-Kumari I had done all my work kindly review it and approve for merge

vaibhavarora102 commented 4 years ago

@Kajol-Kumari can you pls check now

vaibhavarora102 commented 4 years ago

Kindly now take it for final review

Kajol-Kumari commented 4 years ago

Kindly now take it for final review Hey @vaibhavarora102 I can see still 8 commits in this PR please squash them in a single one.

vaibhavarora102 commented 4 years ago

Hi @Kajol-Kumari Can I expect now my pr to get merged soon

SanketDG commented 4 years ago

I don't like this being done manually, why not just use https://allcontributors.org/docs/en/cli/overview for now, and then we can see if we can get the bot integrated by some maintainer.

Kajol-Kumari commented 4 years ago

I don't like this being done manually, why not just use https://allcontributors.org/docs/en/cli/overview for now, and then we can see if we can get the bot integrated by some maintainer.

I don't like this being done manually, why not just use https://allcontributors.org/docs/en/cli/overview for now, and then we can see if we can get the bot integrated by some maintainer.

@SanketDG If we go on adding with this ^ then:

  1. It will just add extra dev-dependency which we won't require after the bot installation.
  2. I am not sure, if we would be able to create the contributor list using this CLI from a fork repo. for the main repo.using this ^
Kajol-Kumari commented 4 years ago

Hi @Kajol-Kumari Can I expect now my pr to get merged soon

@vaibhavarora102 All the PRs having 2 or more approvals will be merged but only after the event ends. So, if your PR has got atleast two approvals, it's good to go and you can work on other PRs.

vaibhavarora102 commented 4 years ago

Actually it was on my default branch So, I could only work freely once it's merged

And I think it's been approved by 2 times and it's a kind request to merge if everything is well

Kajol-Kumari commented 4 years ago

Hey @vaibhavarora102 we can't merge any of the PR before the end of the event and participants are always supposed to create a branch and then start working on an issue. SO i would recommend you to make a fresh fork, create a branch, make th erequired changes , close this Pr and open up a new one.

SanketDG commented 4 years ago
  1. It will just add extra dev-dependency which we won't require after the bot installation.

I am not sure I follow, I am asking for the cli to be used once to generate the files in README.md and then send the PR. Exactly what's being done now, except through a tool and not manually.

2. I am not sure, if we would be able to create the contributor list using this CLI from a fork repo. for the main repo.using this ^

Again, I do not follow, it's just like changing a file and sending a PR right? The diff would be against README.md

Later we just integrate this with the bot itself (when a maintainer does this)

Kajol-Kumari commented 4 years ago
  1. It will just add extra dev-dependency which we won't require after the bot installation.

I am not sure I follow, I am asking for the cli to be used once to generate the files in README.md and then send the PR. Exactly what's being done now, except through a tool and not manually.

  1. I am not sure, if we would be able to create the contributor list using this CLI from a fork repo. for the main repo.using this ^

Again, I do not follow, it's just like changing a file and sending a PR right? The diff would be against README.md

Later we just integrate this with the bot itself (when a maintainer does this)

@SanketDG I hadn't got your proposal properly. This sounds good to me. @vaibhavarora102 can you please integrate the CLI and create the contributor list using that only. Also as you have created this PR using your master branch. Please clone this one and make a new PR through a particular branch dedicated for this issue.