Fixed logout position

[priyanshurohilla]

Description

Fixed logout position

Fixes #1031

Type of Change:

Delete irrelevant options.

• Code

Code/Quality Assurance Only

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

tests have been performed locally

Checklist:

Delete irrelevant options.

• [x] My PR follows the style guidelines of this project
• [x] I have performed a self-review of my own code or materials

Code/Quality Assurance Only

• [x] My changes generate no new warnings
• [x] New and existing unit tests pass locally with my changes
• [x] Any dependent changes have been published in downstream modules

[priyanshurohilla]

@priyanshurohilla codewise LGTM! Can you please try re-runing the build here?

@Kajol-Kumari Can you please tell me how do i re-run the build?

[Kajol-Kumari]

@priyanshurohilla codewise LGTM! Can you please try re-runing the build here?

@Kajol-Kumari Can you please tell me how do i re-run the build?

@priyanshurohilla pushing a new commit will re-run the build automatically.

[priyanshurohilla]

@priyanshurohilla codewise LGTM! Can you please try re-runing the build here?

@Kajol-Kumari Can you please tell me how do i re-run the build?

@priyanshurohilla pushing a new commit will re-run the build automatically.

@Kajol-Kumari So is it like I hard reset git then i again make the changes and push it?

[Kajol-Kumari]

@priyanshurohilla you can just make minor change like putting a space in this line before and after {% trans "Log Out" %} , commit the change and push it to the branch with which you have made this PR.

[keshakaneria]

@priyanshurohilla Are you still working on the issue assigned and changes requested?

[priyanshurohilla]

Yes it is done, I will open the commit again

[priyanshurohilla]

@priyanshurohilla you can just make minor change like putting a space in this line before and after {% trans "Log Out" %} , commit the change and push it to the branch with which you have made this PR.

@Kajol-Kumari Again the same issue is coming

[keshakaneria]

@Kajol-Kumari Again the same issue is coming

Any updates @priyanshurohilla?

[priyanshurohilla]

@Kajol-Kumari Again the same issue is coming

Any updates @priyanshurohilla?

I made the changes as suggested by @Kajol-Kumari and made the commit , but the build is being failed again. I dont know what is happening

[keshakaneria]

@Kajol-Kumari Again the same issue is coming

Any updates @priyanshurohilla?

I made the changes as suggested by @Kajol-Kumari and made the commit , but the build is being failed again. I dont know what is happening

The build is failing due to this error by ../tests/test_login.py. Did you try to run the tests? Try once in your local to run the tests and solve the error and push it again

[Kajol-Kumari]

Hey @priyanshurohilla your build is failing 'coz of this line. As you can see the assertion Error here, you need to make the changes in this test.

[priyanshurohilla]

Hey @priyanshurohilla your build is failing 'coz of this line. As you can see the assertion Error here, you need to make the changes in this test.

@Kajol-Kumari Can you suggest me which changes to make?

[Kajol-Kumari]

Hey @priyanshurohilla your build is failing 'coz of this line. As you can see the assertion Error here, you need to make the changes in this test.

@Kajol-Kumari Can you suggest me which changes to make?

Hey @priyanshurohilla changing this line to self.live_server_url + PageUrls.homepage will resolve this issue but the server isn't giving the correct response here. so i would recommend you to spend some time to figure out why the response isn't coming as expected by this test case.

\cc: @satya7289

[keshakaneria]

Any updates?

[keshakaneria]

@priyanshurohilla Are you done with the changes?

[keshakaneria]

Did you run the test_change_password test? It has errors which is why the build is failing.

[priyanshurohilla]

I did the changes as suggested by @Kajol-Kumari .I seriously can't understand this was such an easy issue, why is it giving such errors I don't know

[keshakaneria]

Are you still figuring this out? @priyanshurohilla