search

anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.
GNU General Public License v2.0
1 stars 4 forks source link

docs: add a codecov badge (#1062) #1064

Closed aniketrb-github closed 4 years ago

aniketrb-github commented 4 years ago

Description

Fixes #1062

Type of Change:

How has this been tested?

Before Changes were made: before-1062-fix

After Changes were made: after-1062-fix

Checklist:

Code/Quality Assurance Only

aniketrb-github commented 4 years ago

Looks great now. One last thing you should do, squash the commits to one commit.

Hi @satya7289, I have squashed the commits into a single commit. Can you please review it. Thanks.

satya7289 commented 4 years ago

Looks great now. One last thing you should do, squash the commits to one commit.

Hi @satya7289, I have squashed the commits into a single commit. Can you please review it. Thanks.

I see there are 5 commits in this PR. Please squash it to 1 commit. If you facing any difficulty in squashing then please let me know.

aniketrb-github commented 4 years ago

Looks great now. One last thing you should do, squash the commits to one commit.

Hi @satya7289, I have squashed the commits into a single commit. Can you please review it. Thanks.

I see there are 5 commits in this PR. Please squash it to 1 commit. If you facing any difficulty in squashing then please let me know.

I did this squash commit action on my 3 distinct commits into a single commit for the first time yesterday & it was successful. This is the new squashed commit that is formed after the squash action performed by me via gitbash. I used the "s"/"squash" option instead of "f"/"fixup". Attaching the screenshot. squash-ss Maybe I should have tried to squash not using the 's'/'squash' and rather use the "f"/"fixup" option. @satya7289 Should I delete this branch, create a new branch, apply the changes again & create new PR?

aniketrb-github commented 4 years ago

@satya7289, I have done the commit squash activity once again, just new with this activity. Can you please check my branch's commit history once? And this is my child branch. Please let me know If this suffices? Thanks

aniketrb-github commented 4 years ago

Yes, This looks great. Thank you for submitting this PR. You should take other issues as well for successful Open Source Hack, Happy coding..!

Thanks @satya7289. You've been patient and helpful with a first timer like me. Sure I'm looking forward to submit more PRs.

aniketrb-github commented 4 years ago

@satya7289 1) Just out of curiosity, basically how many reviews are necessary for a PR to be seen fit to be merged in the master/main branch? 2) And while the review process is onn, I can work on other issues in parallel right?

satya7289 commented 4 years ago

@satya7289 1) Just out of curiosity, basically how many reviews are necessary for a PR to be seen fit to be merged in the master/main branch? 2) And while the review process is onn, I can work on other issues in parallel right?

1> min 2. 2>yes, please. You can work on others issue in parallel.

aniketrb-github commented 4 years ago

@satya7289

  1. Just out of curiosity, basically how many reviews are necessary for a PR to be seen fit to be merged in the master/main branch?
  2. And while the review process is on, I can work on other issues in parallel right?

1> min 2. 2>yes, please. You can work on others issue in parallel.

oh ok, got it. thanks.

gaurivn commented 4 years ago

@satya7289, Idk it says I deleted, was trying to delete my previous review.

@aniketrb-github, thank you for your contribution :clap:

aniketrb-github commented 3 years ago

Hi @isabelcosta and @satya7289 I have a small query regarding this commit merge, just trying to understand the phase/cycle here. Once a commit is merged, should we expect to view those code changes on the develop branch immediately?

If YES, I just checked the develop branch but I didn't see the codecov badge in the README.MD file for which I had made the changes.

If NO, then we do the code changes get integrated & start reflecting in the develop branch.

isabelcosta commented 3 years ago

@aniketrb-github you should be able to see it on the README right away. I think it got mistakenly deleted in this commit: https://github.com/anitab-org/vms/commit/bd155a6ee3fbaa18964bd85c2d6a14829a74fc8c

Could you submit a PR again with the badge? I am sorry we didn't notice this with the other PR https://github.com/anitab-org/vms/pull/1107

Thank you for bringing that up, we should pay more attention next time 🙈

aniketrb-github commented 3 years ago

@aniketrb-github you should be able to see it on the README right away. I think it got mistakenly deleted in this commit: bd155a6

Could you submit a PR again with the badge? I am sorry we didn't notice this with the other PR #1107

Thank you for bringing that up, we should pay more attention next time

Is it possible to reuse or reopen this PR and use it again? (if it is possible) If not possible, I will have to create a new PR. I had forked develop branch, and have contributed to 1047 issue as well. So now I'm a bit confused now since for new PR I will need a fresh fork, and If I delete the existing fork & create anew, will this affect my other PR for issue-1047 since it is still not merged yet? What should I do please let me know. Thanks

isabelcosta commented 3 years ago

@aniketrb-github its not possible to re open, you have to open another PR :/ You can create a new branch, and first update your develop branch. Do you know how to do that?

aniketrb-github commented 3 years ago

@aniketrb-github it's not possible to reopen, you have to open another PR :/ You can create a new branch, and first update your develop branch. Do you know how to do that?

Ok fine no problem, I will submit a new PR.

Here's the new pull request. Kindly review it Thanks.