Closed khushishikhu closed 4 years ago
@rkpattnaik780 please review my PR and let me know what other changes i need to do to make it better.
@khushishikhu since most of the sections dont depend on platform, can we just add the specific sections and not all of them. Maybe we can just have a "one-time setup in RHEL/Fedora" just below the existing "A one-time setup" and do something similar for "Testing session".
@rkpattnaik780 okay, i will update you with those changes
@rkpattnaik780 i don't know why but i am not able to squash the commits
@rkpattnaik780 i don't know why but i am not able to squash the commits
You can refer this article, if your problem is not being covered here, please let me know in this thread, attach screenshots if needed.
@rkpattnaik780 i don't know why but i am not able to squash the commits
You can refer this article, if your problem is not being covered here, please let me know in this thread, attach screenshots if needed.
actually it's not showing my commits in my branch whenever i run git rebase -i HEAD~3
@rkpattnaik780 i don't know why but i am not able to squash the commits
You can refer this article, if your problem is not being covered here, please let me know in this thread, attach screenshots if needed.
actually it's not showing my commits in my branch whenever i run
git rebase -i HEAD~3
Seems you are in the develop branch. Can you confirm that you are in branch patch-1-1
by checking the output of git branch
and then check your commit history through git log
.
in commit history it's not showing me my commits
I would suggest to make a new commit. That would need you to reset the current changes and copy paste from the files already pushed to github. Try to do the following steps:
Hopefully these will get the work done.
@rkpattnaik780 actually somehow i got to know by myself that why my commits were not squashing. thank you
@rkpattnaik780 actually somehow I got to know by myself that why my commits were not squashing. thank you
Hi @rkpattnaik780 and @khushishikhu. I'm just leaving these two links here which I found were very easy to understand, learn & execute with necessary pre-requisites regarding commit squash. just a few commands on terminal/gitbash prompt like:
git log
or use git log --oneline
git rebase -i HEAD~4
Why the number 4? That's explained great in those 2 clips.I just learned the commit squash concept yesterday & did struggle a little bit...but later got over it due to the above links shared. Thanks. :)
@rkpattnaik780 now can i just go for other issues to work for OSH
@rkpattnaik780 now can i just go for other issues to work for OSH
Go ahead.
Thank you @isabelcosta for reviewing my PR . I have done the required changes
@rkpattnaik780 please review my PR
Squash the commits.
@rkpattnaik780 i have squashed the commits
Description
Installation guide for RHEL/Feroda
Fixes #1051
Type of Change:
How Has This Been Tested?
Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.
Checklist:
Code/Quality Assurance Only