atharwa-24 commented 4 years ago

Description

Added the Python version badge to the README file. Additionally added logos to the Travis ,Zulip and Python Badge in README file.

Type of Change:

doc:

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

vms before badge

vms after badge

Delete irrelevant options.

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] Any dependent changes have been merged

Code/Quality Assurance Only

[x] My changes generate no new warnings
[ ] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[ ] Any dependent changes have been published in downstream modules

atharwa-24 commented 4 years ago

Hey thanks for this one i wasn't known to the concept of Updating pull requests learnt to apply the changes in the existing PR

atharwa-24 commented 4 years ago

ok @SanketDG

atharwa-24 commented 4 years ago

@SanketDG Done

atharwa-24 commented 4 years ago

@SanketDG @rkpattnaik780 Please review the changes

rkpattnaik780 commented 4 years ago

Add “fixes #” in the commit body as well.

rkpattnaik780 commented 4 years ago

The commits needed to be squashed, any reason you closed this PR @atharwa-24

atharwa-24 commented 4 years ago

i had messed up while squashing the PR @rkpattnaik780

atharwa-24 commented 4 years ago

I will make the changes and will put a new PR

rkpattnaik780 commented 4 years ago

Try to fix this PR. Let me know if you need help.

atharwa-24 commented 4 years ago

Try to fix this PR. Let me know if you need help.

I tried to fix that one but its not reopening

rkpattnaik780 commented 4 years ago

Can we just select certain commits and make the PR

Okay, make a fresh PR then.