anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.

GNU General Public License v2.0

1 stars 4 forks source link

docs: added Python version Badge #1078

Closed atharwa-24 closed 4 years ago

atharwa-24 commented 4 years ago

Description

Added Python Version Badge to README file, logos to the Existing Badges in the README file Removed extra blanc line

Type of Change:

Documentation

Code/Quality Assurance Only

Bug fix (non-breaking change which fixes an issue)
This change requires a documentation update (software upgrade on readme file)
New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

before

vms

after

vms2

Checklist:

Delete irrelevant options.

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] Any dependent changes have been merged

Code/Quality Assurance Only

[x] My changes generate no new warnings
[x] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been published in downstream modules

rkpattnaik780 commented 4 years ago

Remove fixes .. from commit header, it should only be in commit body.

atharwa-24 commented 4 years ago

Remove fixes .. from commit header, it should only be in commit body.

Done

rkpattnaik780 commented 4 years ago

Remove fixes .. from commit header, it should only be in commit body.

Done

Hello @atharwa-24 , you are required to change the header of your commit. Do a git commit --amend, edit the header and then do a git push -f origin develop.

atharwa-24 commented 4 years ago

LGTM! Thanks

Can you plz explain why the checks r getting failed I am not able to figure it out @rkpattnaik780 how to fig it out?

rkpattnaik780 commented 4 years ago

LGTM! Thanks

Can you plz explain why the checks r getting failed I am not able to figure it out @rkpattnaik780 how to fig it out?

Can you post it in the zulip chat? I am not sure why markdown related change is failing the build.

atharwa-24 commented 4 years ago

Hey @rkpattnaik780 the build has passed!!!

rkpattnaik780 commented 4 years ago

Undo the changes of your second commit, squash and force push again. The build will pass it seems.

rkpattnaik780 commented 4 years ago

It shows the older build still can you try out the following steps: git reset HEAD^ git commit (give the appropriate commit head and commit body) git push -f origin develop

atharwa-24 commented 4 years ago

added the reason for build fail in zulip chat