anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.
GNU General Public License v2.0
1 stars 4 forks source link

Bug: Modified create_organization function #1079

Open decon-harsh opened 4 years ago

decon-harsh commented 4 years ago

Modified create_organization function to handle Integrity Error which happens when user enters unlisted non unique organization.

Fixes #1042

Type of Change:

Mocks

Screenshot of Error

Screenshot from 2020-09-02 02-49-56

After the changes

Volunteer account gets created!

Registration with Unlisted Organisation "New Organization"

Issue_1042

"New Organization" Exist in database

Screenshot from 2020-09-05 11-42-25

Registration with Listed Organisation (not approved)

Issue_1042(2)

Login

Screenshot from 2020-09-05 11-59-44

Screenshot from 2020-09-05 11-59-21

Code/Quality Assurance Only

How Has This Been Tested?

Manually tested

Instructions to reproduce

Checklist:

Delete irrelevant options.

Code/Quality Assurance Only

decon-harsh commented 4 years ago

Codewise LGTM! @decon-harsh please do the following changes: 1.update the issue description with a GIF showing the fix

  1. Fix the flake8 error. you can take reference from here to here.

On it!

decon-harsh commented 4 years ago

Will add a gif

decon-harsh commented 4 years ago

Added necessary gif and pics.

Would like to show a new error.While Signing up as a volunteer , the city , country and state field has neither dropdowns nor their value gets saved the last screenshot clearly states the blank fields.

I have opened one issue regarding the dropdown but it has not been yet reviewed. If you say I will love to work on both these issues.

@Kajol-Kumari

Ps: Sorry I am bad with giving names to databases and enteries :)

decon-harsh commented 4 years ago

Check this @Kajol-Kumari

satya7289 commented 4 years ago

Would like to show a new error.While Signing up as a volunteer , the city , country and state field has neither dropdowns nor their value gets saved the last screenshot clearly states the blank fields.

I have opened one issue regarding the dropdown but it has not been yet reviewed. If you say I will love to work on both these issues.

Regarding this, Have you migrate the cities light?

satya7289 commented 4 years ago

I guess yes , because it's working for admin but not for volunteer

In the last pic , it's evident there is a drop down when you try to edit those. But in the start there is not .

I will make migrations once again and will check.

Yes, Please check and confirm here. Thanks

decon-harsh commented 4 years ago

@satya7289 the issue got solved , when i recreated the database and again made migrations!