docs: add Installation guide for Windows OS

[ashwinijha6]

Description

Installation guide for Windows OS

Fixes #1036

Type of Change:

• Code
• Quality Assurance
• Documentation/Training

How Has This Been Tested?

Describe the tests you ran to verify your changes. Provide instructions or GIFs so we can reproduce. List any relevant details for your test.

Checklist:

Delete irrelevant options.

• [x] My PR follows the style guidelines of this project
• [x] I have performed a self-review of my own code or materials
• [x] I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
• [x] I have made corresponding changes to the documentation
• [x] Any dependent changes have been merged

Code/Quality Assurance Only

• [ ] My changes generate no new warnings
• [ ] My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes
• [ ] Any dependent changes have been published in downstream modules

[keshakaneria]

Otherwise, it seems perfect! @Kajol-Kumari @satya7289 suggest if something is missing

[ashwinijha6]

@keshakaneria & @Kajol-Kumari I have made the necessary changes, pls review them

[ashwinijha6]

I don't understand why the build is failing @keshakaneria

[keshakaneria]

I don't understand why the build is failing @keshakaneria

Did you run tests before pushing it?

[ashwinijha6]

I don't understand why the build is failing @keshakaneria

Did you run tests before pushing it?

No actually I made changes on git itself that is edited the file there & pushed the changes in the same branch so I guess the test didn't run. What should I do ?

[ashwinijha6]

I don't understand why the build is failing @keshakaneria

Did you run tests before pushing it?

But the checks took place for about 19 mins I guess only one failed It say's The build failed. This is a change from the previous build, which passed

[keshakaneria]

I don't understand why the build is failing @keshakaneria

Did you run tests before pushing it?

No actually I made changes on git itself that is edited the file there & pushed the changes in the same branch so I guess the test didn't run. What should I do ?

Edit the file locally and push the changes in the file you created in your branch which will eventually reflect here. Also remove 'cmd' written after markdowns to show the code snippet.

[ashwinijha6]

I don't understand why the build is failing @keshakaneria

Did you run tests before pushing it?

No actually I made changes on git itself that is edited the file there & pushed the changes in the same branch so I guess the test didn't run. What should I do ?

Edit the file locally and push the changes in the file you created in your branch which will eventually reflect here. Also remove 'cmd' written after markdowns to show the code snippet.

Should I work on the same branch or create another one ?

[Kajol-Kumari]

@ashwinijha6 I can now see the word cmd here and here Can you please fix this? Also, If i am not wrong the build isn't failing due to the changes you have done, probably there is some issue of versioning in the requirements.txt that is leading the build fail. so I would say not to worry about the build as of now.

[ashwinijha6]

@ashwinijha6 I can now see the word cmd here and here Can you please fix this? Also, If i am not wrong the build isn't failing due to the changes you have done, probably there is some issue of versioning in the requirements.txt that is leading the build fail. so I would say not to worry about the build as of now.

@Kajol-Kumari I will remove the cmd from the md file where ever it is present. but the previous build passed with the same file versions as in requirements.txt. I'll try making the changes locally & then pushing it. Thanku for ur review.

[keshakaneria]

Should I work on the same branch or create another one ?

Working on the same branch locally can help you. If you create a new branch, you will have to send another PR, so better work on the same PR itself.

[ashwinijha6]

@keshakaneria & @Kajol-Kumari Ihave made the required changes.

[ashwinijha6]

Just squash your commits to a single commit before it is ready to merge

ok I will do that

[ashwinijha6]

This is really exhaustive work, thank you for doing this @ashwinijha6

I see that some of the things are not wrong in the preview especially "links in code blocks" is not going to work.

@SanketDG I will rectify them I don't know why that is happening I guess its because I have put them in ``` ?

[keshakaneria]

@SanketDG I will rectify them I don't know why that is happening I guess its because I have put them in ``` ?

Yes, you can better remove the code block and directly hyperlink the word. For ex. Download Python

[ashwinijha6]

@SanketDG I will rectify them I don't know why that is happening I guess its because I have put them in ``` ?

Yes, you can better remove the code block and directly hyperlink the word. For ex. Download Python

Ok I will remove the code blocks for the fields which includes the link Thanku @keshakaneria & @SanketDG for the review

[ashwinijha6]

@keshakaneria & @SanketDG I have made the changes pls review.

[keshakaneria]

Also, the build is failed, may be there is no new line at the end of the file. Add the new line, we'll see if the build passes

[ashwinijha6]

Also, the build is failed, may be there is no new line at the end of the file. Add the new line, we'll see if the build passes

What do u mean by new line?

[ashwinijha6]

Also, the build is failed, may be there is no new line at the end of the file. Add the new line, we'll see if the build passes

What do u mean by new line?

Do u mean just enter?

[keshakaneria]

Also, the build is failed, may be there is no new line at the end of the file. Add the new line, we'll see if the build passes

What do u mean by new line?

Do u mean just enter?

Yes a new line but just an enter

[ashwinijha6]

Also, the build is failed, may be there is no new line at the end of the file. Add the new line, we'll see if the build passes

What do u mean by new line?

Do u mean just enter?

Yes a new line but just an enter

ok ok I'm doing it right now

[ashwinijha6]

@keshakaneria done.

[keshakaneria]

Congratulations for your successful PR! Its ready to merge!

[ashwinijha6]

Congratulations for your successful PR! Its ready to merge!

Thanku @keshakaneria . Should I squash the commits?

[ashwinijha6]

@keshakaneria do I have to squash commits?

[keshakaneria]

@keshakaneria do I have to squash commits?

Oops! My mistake, I just forgot to tell you to squash them. Yes, do squash them carefully and then it'll be fine👍

[ashwinijha6]

@keshakaneria do I have to squash commits?

Oops! My mistake, I just forgot to tell you to squash them. Yes, do squash them carefully and then it'll be fine👍

I have never done squashing before so we have to change pick to squash right for all the commits before & let the last be as it is?

[keshakaneria]

@keshakaneria do I have to squash commits?

Oops! My mistake, I just forgot to tell you to squash them. Yes, do squash them carefully and then it'll be fine👍

I have never done squashing before so we have to change pick to squash right for all the commits before & let the last be as it is?

Yes even s would work. Replace pick to s and keep the last one as it is.

[ashwinijha6]

 @keshakaneria this should do or it has to be the other way round?

[keshakaneria]

 @keshakaneria this should do or it has to be the other way round?

I didn't get you

[ashwinijha6]

 @keshakaneria this should do or it has to be the other way round?

I didn't get you

Can u see the sreenshot?

[ashwinijha6]

[keshakaneria]

Perfect Go for it! Save and push it again

[ashwinijha6]

The image in the screenshot is good go with right? Squashing all the commits before to the last one will let the last changes be as it is Squashing is just for making one commit or the changes are also reflected?

[ashwinijha6]

Perfect Go for it! Save and push it again

ok I will do that

[keshakaneria]

The image in the screenshot is good go with right? Squashing all the commits before to the last one will let the last changes be as it is Squashing is just for making one commit or the changes are also reflected?

The commit count will change from 5 to 1. This shows that you have squashed all the commits to the single one. For saving press Esc key, type :wq! and press Enter key to save

[ashwinijha6]

It is giving me an error cannot squash with previous commit?

[ashwinijha6]

It is giving me an error cannot squash with previous commit?

Sorry Cannot squash without previous commit

[keshakaneria]

It is giving me an error cannot squash with previous commit?

Try this link. If it still doesnt work, let us discuss on Zulip Channel rather than here.

[SanketDG]

From what I see, you just need to do it in reverse i.e. keep the first (newest) commit as pick and the rest as squash:slightly_smiling_face:

[ashwinijha6]

From what I see, you just need to do it in reverse i.e. keep the first (newest) commit as pick and the rest as squash🙂

yes I did that @SanketDG but the first commit in the screenshot docs: Add Installation Guide for Windows OS is not the newest

[keshakaneria]

You did the other way round keeping the oldest as pick but i think our work is done. Commit count shows 1. So we are fine with it i suppose.

[ashwinijha6]

Done u can review it once @keshakaneria & @SanketDG

[ashwinijha6]

Good job 👍

Thanx @keshakaneria is it ready to merge?

[keshakaneria]

Good job 👍

Thanx @keshakaneria is it ready to merge?

Yes it is!

[ashwinijha6]

@SanketDG @Kajol-Kumari could anyone pls review my pull request as it requires 2 approved reviews.

[ashwinijha6]

LGTM 👍

Thanku @Kajol-Kumari @keshakaneria now it has been reviewed by 2 mentors ?

[keshakaneria]

Thanku @Kajol-Kumari @keshakaneria now it has been reviewed by 2 mentors ?

Yes, @isabelcosta have requested the maintainers to get it checked. She'll further look into it :) We are done with our side 👍

[ashwinijha6]

Thanku @Kajol-Kumari @keshakaneria now it has been reviewed by 2 mentors ?

Yes, @isabelcosta have requested the maintainers to get it checked. She'll further look into it :) We are done with our side 👍

ok