anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.
GNU General Public License v2.0
1 stars 4 forks source link

Add the newcomers link #1083

Closed vaibhavarora102 closed 4 years ago

vaibhavarora102 commented 4 years ago

Description

Added newcomers zulip link in the ReadMe.

Fixes #1039

Type of Change:

Delete irrelevant options.

How Has This Been Tested?

git Just changed readme

Checklist:

Delete irrelevant options.

satya7289 commented 4 years ago

@vaibhavarora102 please follow the commits message guildlines, also add how you tested by adding screenshots.

vaibhavarora102 commented 4 years ago

git

kindly check screen shot and can you pls tell what guidelines you are talking of thanks @satya7289

satya7289 commented 4 years ago

git

kindly check screen shot and can you pls tell what guidelines you are talking of thanks @satya7289

Add the screenshot to the description of the PR. Here is the guildlines https://github.com/anitab-org/vms/wiki/Commit-Message-Style-Guide

vaibhavarora102 commented 4 years ago

@satya7289 is it okay now

satya7289 commented 4 years ago

@satya7289 is it okay now

Please add the screenshot to the How has this tested section.also squash the commits to 1 commit and follow commits message guildlines.

vaibhavarora102 commented 4 years ago

@satya7289 I had made respective changes in the PR, being new to open source I don't know the way to squash all the commits as they are already pushed. and had pushed two or from the same branch so, if I try to do change both will change kindly help.

satya7289 commented 4 years ago

@satya7289 I had made respective changes in the PR, being new to open source I don't know the way to squash all the commits as they are already pushed. and had pushed two or from the same branch so, if I try to do change both will change kindly help.

If you do some Google you will come to know how to do it. This might help, https://www.internalpointers.com/post/squash-commits-into-one-git https://github.com/satya7289/Compter-Science-Stuffs/tree/master/git