Bug: Fixed binary string in the url of email verification

[decon-harsh]

The url's uid was a b string. Decoded the uid to string. Removed some flake8 errors.

Fixes #1061

Type of Change:

• Code
• Quality Assurance

Code/Quality Assurance Only

• Bug fix (non-breaking change which fixes an issue)

Mocks

How Has This Been Tested?

Manually

Checklist:

• [X] My PR follows the style guidelines of this project
• [X] I have performed a self-review of my own code or materials

Code/Quality Assurance Only

• [X] My changes generate no new warnings

[decon-harsh]

On it

[decon-harsh]

Done

No errors

[decon-harsh]

Okay this is weird , I almost made no change and the build failed !

[atharwa-24]

Okay this is weird , I almost made no change and the build failed

Same problem faced The build is getting failed. on #1078

[decon-harsh]

Lmao I re runned it and it passed, haha!

[isabelcosta]

@anitab-org/qa-team can anyone test this? @decon-harsh can you let us know how you tested this?

[decon-harsh]

@isabelcosta I ran all the test cases locally and checked it manually whether the correct link was getting generated . Images in mocks

[decon-harsh]

Hey @satya7289 just a question . Since I worked on the test cases in this issue , Doesn't that makes it a quality assurance too?Please correct me if I am wrong!

[satya7289]

Hey @satya7289 just a question . Since I worked on the test cases in this issue , Doesn't that makes it a quality assurance too?Please correct me if I am wrong!

Agree.

[decon-harsh]

Hey @satya7289 just a question . Since I worked on the test cases in this issue , Doesn't that makes it a quality assurance too?Please correct me if I am wrong!

Agree.

Can you add the tag for the OSH please :)

[satya7289]

Hey @satya7289 just a question . Since I worked on the test cases in this issue , Doesn't that makes it a quality assurance too?Please correct me if I am wrong!

Agree.

Can you add the tag for the OSH please :)

This issue is already a part of OSH.

[decon-harsh]

Hey @satya7289 just a question . Since I worked on the test cases in this issue , Doesn't that makes it a quality assurance too?Please correct me if I am wrong!

Agree.

Can you add the tag for the OSH please :)

This issue is already a part of OSH.

I was talking about quality assurance tag

[decon-harsh]

@devkapilbansal done please check

[codecov[bot]]

Codecov Report

Merging #1086 into develop will increase coverage by 0.41%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop    #1086      +/-   ##
===========================================
+ Coverage    86.93%   87.35%   +0.41%     
===========================================
  Files           85       85              
  Lines         4057     4057              
  Branches       237      237              
===========================================
+ Hits          3527     3544      +17     
+ Misses         458      441      -17     
  Partials        72       72              

Impacted Files	Coverage Δ
vms/registration/views.py	82.35% <0.00%> (+3.20%)	:arrow_up:
vms/shift/views.py	63.60% <0.00%> (+2.20%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update eb63dfd...68a4842. Read the comment docs.

[devkapilbansal]

@decon-harsh codecov is not able to calculate test coverage as your branch is behind. Please rebase it to current develop. After that, I will test if it works properly and it can be labelled as Ready to Merge then

Also squash them to one and follow commit guidelines

[decon-harsh]

Messed up? @devkapilbansal

What should I do now? Should I close this and again open a new PR?

[devkapilbansal]

@decon-harsh you should move back to the commit you do 3 hours before

git reset --hard c237667
git remote add upstream https://github.com/anitab-org/vms.git
git fetch upstream develop
git rebase upstream/develop
git push -f

After it is done, test it locally to ensure nothing breaks. You may need to solve any merge conflicts manually

[decon-harsh]

other errors are coming up , let me close this pull and open another! @devkapilbansal