Closed decon-harsh closed 4 years ago
On it
Done
No errors
Okay this is weird , I almost made no change and the build failed !
Okay this is weird , I almost made no change and the build failed
Same problem faced The build is getting failed. on #1078
Lmao I re runned it and it passed, haha!
@anitab-org/qa-team can anyone test this? @decon-harsh can you let us know how you tested this?
@isabelcosta I ran all the test cases locally and checked it manually whether the correct link was getting generated . Images in mocks
Hey @satya7289 just a question . Since I worked on the test cases in this issue , Doesn't that makes it a quality assurance too?Please correct me if I am wrong!
Hey @satya7289 just a question . Since I worked on the test cases in this issue , Doesn't that makes it a quality assurance too?Please correct me if I am wrong!
Agree.
Hey @satya7289 just a question . Since I worked on the test cases in this issue , Doesn't that makes it a quality assurance too?Please correct me if I am wrong!
Agree.
Can you add the tag for the OSH please :)
Hey @satya7289 just a question . Since I worked on the test cases in this issue , Doesn't that makes it a quality assurance too?Please correct me if I am wrong!
Agree.
Can you add the tag for the OSH please :)
This issue is already a part of OSH.
Hey @satya7289 just a question . Since I worked on the test cases in this issue , Doesn't that makes it a quality assurance too?Please correct me if I am wrong!
Agree.
Can you add the tag for the OSH please :)
This issue is already a part of OSH.
I was talking about quality assurance tag
@devkapilbansal done please check
Merging #1086 into develop will increase coverage by
0.41%
. The diff coverage is0.00%
.
@@ Coverage Diff @@
## develop #1086 +/- ##
===========================================
+ Coverage 86.93% 87.35% +0.41%
===========================================
Files 85 85
Lines 4057 4057
Branches 237 237
===========================================
+ Hits 3527 3544 +17
+ Misses 458 441 -17
Partials 72 72
Impacted Files | Coverage Δ | |
---|---|---|
vms/registration/views.py | 82.35% <0.00%> (+3.20%) |
:arrow_up: |
vms/shift/views.py | 63.60% <0.00%> (+2.20%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update eb63dfd...68a4842. Read the comment docs.
@decon-harsh codecov is not able to calculate test coverage as your branch is behind. Please rebase it to current develop. After that, I will test if it works properly and it can be labelled as Ready to Merge then
Also squash them to one and follow commit guidelines
Messed up? @devkapilbansal
What should I do now? Should I close this and again open a new PR?
@decon-harsh you should move back to the commit you do 3 hours before
git reset --hard c237667
git remote add upstream https://github.com/anitab-org/vms.git
git fetch upstream develop
git rebase upstream/develop
git push -f
After it is done, test it locally to ensure nothing breaks. You may need to solve any merge conflicts manually
other errors are coming up , let me close this pull and open another! @devkapilbansal
The url's uid was a b string. Decoded the uid to string. Removed some flake8 errors.
Fixes #1061
Type of Change:
Code/Quality Assurance Only
Mocks
How Has This Been Tested?
Manually
Checklist:
Code/Quality Assurance Only