anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.

GNU General Public License v2.0

1 stars 4 forks source link

Added Button in UI to link Zulip #1088

Closed yash2189 closed 3 years ago

yash2189 commented 3 years ago

Description

To add button in UI to link Zulip

Fixes #1038

Type of Change:

User Interface

How Has This Been Tested?

Successfully added button in UI to link Zulip. When a registered user is logged in the button is shown on the home page.

Button_ZULIP

Checklist:

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials

keshakaneria commented 3 years ago

@yash2189 Did you do this locally? I am seeing 15 files are changed. You should edit the files locally and then push it into your forked repo in another branch and then send a PR in 1 commit and required files changed. Also there is some alteration in migrations which wasn't necessary to add a button and link it. Can you tell me what was the need for me to get an idea?

yash2189 commented 3 years ago

apologies @keshakaneria this was my mistake I will do the required changes again. Will do this by the end of the day is it fine?

yash2189 commented 3 years ago

@keshakaneria I was setting up the project so I had done the migrations that was just for testing.

keshakaneria commented 3 years ago

Next time take care to have a look to list of files changed from the git bash before pushing it, so you only push the necessary edited files and nothing unnecessary.