anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.

GNU General Public License v2.0

1 stars 4 forks source link

Added button in UI to link Zulip #1089

Closed yash2189 closed 3 years ago

yash2189 commented 3 years ago

Description

To add button in UI to link Zulip Fixes #1038

Type of Change:

User Interface

How Has This Been Tested?

Successfully added button in UI to link Zulip. When a registered user is logged in the button is shown on the home page.

Screenshots: Button_ZULIP

Checklist:

[x] My PR follows the style guidelines of this project
[x] I have performed a self-review of my own code or materials
[x] Any dependent changes have been merged

yash2189 commented 3 years ago

@keshakaneria I have checked it please review it again.

keshakaneria commented 3 years ago

Also can you let me know why was the images added in docs/screenshots file?

yash2189 commented 3 years ago

I thought the screenshot would be required hence I did. Does it have to be removed or placed in different folder? However I have placed them in a separate folder now called UI_screenshots. If this is fine?

keshakaneria commented 3 years ago

I thought the screenshot would be required hence I did. Does it have to be removed or placed in different folder? However I have placed them in a separate folder now called UI_screenshots. If this is fine?

Well we don't need any screenshots to be uploaded in the repo how the UI looks. So it is better if we dont add any of the screenshots in commits. There should be only the code changed in home.html and nothing else. So remove all those screenshots and push it for the final review. Points to change:

Remove the screenshots
Squash the final commits Hence it will be ready to merge. Otherwise great job @yash2189 ! 👍 :)

yash2189 commented 3 years ago

Surely @keshakaneria I'll do that by tomorrow if that works?

yash2189 commented 3 years ago

@keshakaneria would you please tell me how do I squash those final commits , I haven't used the squash command before.

keshakaneria commented 3 years ago

@keshakaneria would you please tell me how do I squash those final commits , I haven't used the squash command before.

Refer this for squashing https://www.internalpointers.com/post/squash-commits-into-one-git. You'll get to know how it is done.

yash2189 commented 3 years ago

@keshakaneria I have squashed the commits. Would you please check whether I have done it correctly?

keshakaneria commented 3 years ago

@keshakaneria I have squashed the commits. Would you please check whether I have done it correctly?

The commits count still shows me 4. After squashing it will change to a single commit. Try once more if you are able to do.

yash2189 commented 3 years ago

I think I've made some mistake while squashing.Can I please close this PR and make a new PR instead I'd be able to do that quick.

keshakaneria commented 3 years ago

I guess this is not good for you to open 3 PRs for an individual issue. Take care next time if any issue assigned to you.

yash2189 commented 3 years ago

Apologies,I will improve on this surely.

yash2189 commented 3 years ago

@keshakaneria Can you please review this PR #1091 ? The next time I won't make such a mistake apologies.