anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.
GNU General Public License v2.0
1 stars 4 forks source link

style: design homepage wireframe #1090

Open pallavithakare28 opened 3 years ago

pallavithakare28 commented 3 years ago

Description

I have introduced a wireframe design for the homepage namely, design.

Fixes #1034

Type of Change:

Mocks

Design-1 Design1

Checklist:

Delete irrelevant options.

Code/Quality Assurance Only

pallavithakare28 commented 3 years ago

@Kajol-Kumari I have created this new PR, kindly review it, and please let me know your thoughts.

Kajol-Kumari commented 3 years ago

Hey @pallavithakare28 please do the following:

  1. use the updated logo with don't contain the word Systers in it. You can get it from here
  2. you design needs to clean in terms of proper spacing and don't add news , contacts on the homepage instead we can keep a slider on the home page for showing achievements
Kajol-Kumari commented 3 years ago

@anitab-org/design-team can you please review this PR

pallavithakare28 commented 3 years ago

@Kajol-Kumari @anitab-org/design-team PR page is showing error 404. Can you please help me

Kajol-Kumari commented 3 years ago

@Kajol-Kumari @anitab-org/design-team PR page is showing error 404. Can you please help me

@pallavithakare28 sorry but when are you getting 404?

pallavithakare28 commented 3 years ago

@anitab-org/design-team can you please review this PR

Sorry @Kajol-Kumari buti for this PR I am getting a 404

Kajol-Kumari commented 3 years ago

@anitab-org/design-team can you please review this PR

Sorry @Kajol-Kumari buti for this PR I am getting a 404

Ah, @pallavithakare28 that is not the PR link, that's the way to tag vms's design team to review this PR.

pallavithakare28 commented 3 years ago

@Kajol-Kumari ok mam and can you please review the description of this PR once? Because I have uploaded a new wireframe design. Please let me know the correction.

Kajol-Kumari commented 3 years ago

@pallavithakare28 please keep the design you are showing in the PR description currently and remove the other one. Also please squash the commits in a single one.

pallavithakare28 commented 3 years ago

@Kajol-Kumari can you please review the PR as I have removed other designs and also squashed the commits. And also I would like to say thank you for your guidance. Thank you, mam.

pallavithakare28 commented 3 years ago

@pallavithakare28 @Kajol-Kumari Looks good

@keshakaneria Thank you mam, can you please review this PR?

pallavithakare28 commented 3 years ago

Hey @Kajol-Kumari minimum how many approval are required to merge this PR? Just asking for a knowledge :)

keshakaneria commented 3 years ago

Hey @Kajol-Kumari minimum how many approval are required to merge this PR? Just asking for a knowledge :)

It requires minimum 2 reviews. We can change the label to ready to merge i suppose

pallavithakare28 commented 3 years ago

@SanketDG Ok that means there's no meaning of this PR?

SanketDG commented 3 years ago

Ok that means there's no meaning of this PR?

I should not be the only person taking this decision, this is just my opinion, please feel free to ask on Zulip about this.

I also don't know who to tag for VMS, apologies

Kajol-Kumari commented 3 years ago

Hey @pallavithakare28 so we won't be able to merge this PR but we will consider it while evaluating. So don't worry, your hard work will not go in vain :)

\cc: @satya7289

pallavithakare28 commented 3 years ago

Hey @pallavithakare28 so we won't be able to merge this PR but we will consider it while evaluating. So don't worry, your hard work will not go in vain :)

\cc: @satya7289

Thank you @Kajol-Kumari :)

alpha2320 commented 3 years ago

@SanketDG can i redesign this in figma and adobe xd and then can you merge it?