anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.
GNU General Public License v2.0
1 stars 4 forks source link

ui:Changed the position of admin name in profile section #1099

Closed yash2189 closed 1 year ago

yash2189 commented 3 years ago

Description

Change the positioning of the admin name in the profile section Fixes #1044

Type of Change:

How Has This Been Tested?

Centered the text using CSS so that it is clearly visible. Capture

Checklist:

yash2189 commented 3 years ago

@sanchibansal340 why did the build fail?

yash2189 commented 3 years ago

Should I bring that text on center?@SanketDG

yash2189 commented 3 years ago

please review my PR #1099 @sanchibansal340 @SanketDG

yash2189 commented 3 years ago

@sanchibansal340 @SanketDG can you please review my PR

sanchibansal340 commented 3 years ago

Will do @yash2189

yash2189 commented 3 years ago

@SanketDG I have done the required changes. Please review the same.

yash2189 commented 3 years ago

@sanchibansal340 is my PR currently being reviewed. I asked this because it's been about 9 days. Please tell me if I need to change anything.

devkapilbansal commented 3 years ago

@sanchibansal340 , I am not able to re-generate that UI error. Can you please provide me with steps on how to proceed?

sanchibansal340 commented 3 years ago

@devkapilbansal Even I am not able to see the error now. I am not sure. I guess it got fixed.

devkapilbansal commented 3 years ago

@devkapilbansal Even I am not able to see the error now. I am not sure. I guess it got fixed.

@sanchibansal340 then, is this PR still relevant now??

sanchibansal340 commented 3 years ago

@devkapilbansal I guess not.

devkapilbansal commented 3 years ago

Okay, then we should close this pull request and the issue linked with it if it's not relevant.

yash2189 commented 3 years ago

@sanchibansal340 will it be counted as a contribution for OSH? The name was appearing at the leftmost corner and I had centered it by adding CSS