anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.
GNU General Public License v2.0
1 stars 4 forks source link

UI: Made dropdown in admin profile visible #1100

Closed decon-harsh closed 3 years ago

decon-harsh commented 3 years ago

Changed max height of navbar-collapse from 360px to fit content

Fixes #1045

Type of Change:

Code/Quality Assurance Only

Mocks

Screenshot from 2020-09-09 00-58-03 Screenshot from 2020-09-09 00-58-10 Screenshot from 2020-09-09 00-58-14

Checklist:

Delete irrelevant options.

Code/Quality Assurance Only

decon-harsh commented 3 years ago

@sanchibansal340 Do you want me to change the top margin of main container I feel it's liitle extra

sanchibansal340 commented 3 years ago

@decon-harsh Thanks for working so fast. To answer your question, let the margin be.

Kajol-Kumari commented 3 years ago

Hey @decon-harsh can we please decrease the top margin for main container(containing texts) only for small devices as it seems a little off for small devices currently.

decon-harsh commented 3 years ago

Hey @decon-harsh can we please decrease the top margin for main container(containing texts) only for small devices as it seems a little off for small devices currently.

On it !

decon-harsh commented 3 years ago

Hey @Kajol-Kumari decreasing margin-top by hard coding is resulting in bad design i.e , when the hamburger icon is not clicked less margin is not looking good.

Screenshots Screenshot from 2020-09-10 03-11-11 Screenshot from 2020-09-10 03-12-29

So to overcome I made a new js file and some changes in templates too. However, this makes it a Coding issue rather than a UI one. Do you want me to open another issue for this and send a new PR or should I make appropriate changes in this only?

PS: Thanks in advance

Kajol-Kumari commented 3 years ago

Hey @decon-harsh let's not make all these changes in this PR. @sanchibansal340 If you want to go ahead with the proposed changes, feel free to open up a new issue for this and assign it to @decon-harsh as he has already done most part of it.

decon-harsh commented 3 years ago

@sanchibansal340 Will you open the above mentioned issue or should I?

sanchibansal340 commented 3 years ago

@decon-harsh Go ahead