anitab-org / vms

THIS PROJECT IS ARCHIVED. Volunteer Management System.

GNU General Public License v2.0

1 stars 4 forks source link

Update home.html #1101

Open bhumikasharma29 opened 3 years ago

bhumikasharma29 commented 3 years ago

Description

The word "Systers" was replaced with "Anita Borg" on the landing page. Fixes #1049

Type of Change:

Documentation

Code/Quality Assurance Only

This change requires a documentation update (software upgrade on readme file)

Checklist:

[ ] My PR follows the style guidelines of this project
[ ] I have made corresponding changes to the documentation
[ ] Any dependent changes have been merged

Code/Quality Assurance Only

[ ] My changes generate no new warnings

sanchibansal340 commented 3 years ago

@bhumikasharma29 Can you please include the details added on the top below #Description?

sanchibansal340 commented 3 years ago

@bhumikasharma29 I guess let it be Anita Borg Institute Community instead of Anita Borg, an Anita Borg Institute Community

keshakaneria commented 3 years ago

@bhumikasharma29 It shows conflicts that must be resolved first. Once it is done we'll approve the changes. Change looks good to me.

keshakaneria commented 3 years ago

@bhumikasharma29 have you resolved the conflicts? If yes, do commit the changes again so that we can proceed to finalize this PR :)

bhumikasharma29 commented 3 years ago

@keshakaneria I resolved the conflict. Please check.

codecov[bot] commented 3 years ago

Codecov Report

Merging #1101 into develop will decrease coverage by 0.36%. The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1101      +/-   ##
===========================================
- Coverage    87.30%   86.93%   -0.37%     
===========================================
  Files           85       85              
  Lines         4057     4057              
  Branches       237      237              
===========================================
- Hits          3542     3527      -15     
- Misses         445      458      +13     
- Partials        70       72       +2

Impacted Files	Coverage Δ
vms/shift/views.py	`61.40% <0.00%> (-2.21%)`	:arrow_down:
vms/event/views.py	`77.63% <0.00%> (-1.69%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f8a4ea7...32686d5. Read the comment docs.

keshakaneria commented 3 years ago

It is still failing. cc: @gaurivn @satya7289

sanchibansal340 commented 3 years ago

@SanketDG Can you help with why the build is failing?

SanketDG commented 3 years ago

Looks like some unrelated bug to me, but I could be wrong here